Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve performance of seq/map peeks #1206

Merged
merged 3 commits into from
Oct 19, 2024
Merged

Improve performance of seq/map peeks #1206

merged 3 commits into from
Oct 19, 2024

Commits on Oct 19, 2024

  1. Rearrange 'match peek'

    @dtolnay
    dtolnay committed Oct 19, 2024
    Configuration menu
    Copy the full SHA
    2a4cb44 View commit details
    Browse the repository at this point in the history

  2. Handle early return sooner on eof in seq or map 

    This matches how peeking is done within deserialize_any and other
Deserializer methods
    @dtolnay
    dtolnay committed Oct 19, 2024
    Configuration menu
    Copy the full SHA
    0f54a1a View commit details
    Browse the repository at this point in the history

  3. Clearer order of comparisons 

    We look at seq.first/map.first only once.
    @dtolnay
    dtolnay committed Oct 19, 2024
    Configuration menu
    Copy the full SHA
    f2082d2 View commit details
    Browse the repository at this point in the history