Explicitly enable indexmap/std #885
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dtolnay
added a commit
that referenced
this pull request
May 3, 2022
As indicated in the summary of #885.
crapStone
added a commit
to Calciumdibromid/CaBr2
that referenced
this pull request
May 13, 2022
This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [serde_json](https://github.com/serde-rs/json) | dependencies | patch | `1.0.79` -> `1.0.81` | --- ### Release Notes <details> <summary>serde-rs/json</summary> ### [`v1.0.81`](https://github.com/serde-rs/json/releases/v1.0.81) [Compare Source](serde-rs/json@v1.0.80...v1.0.81) - Work around `indexmap`/`autocfg` not always properly detecting whether a `std` sysroot crate is available ([#​885](serde-rs/json#885), thanks [@​cuviper](https://github.com/cuviper)) ### [`v1.0.80`](https://github.com/serde-rs/json/releases/v1.0.80) [Compare Source](serde-rs/json@v1.0.79...v1.0.80) - Documentation improvements </details> --- ### Configuration 📅 **Schedule**: At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, click this checkbox. --- This PR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate). Co-authored-by: cabr2-bot <cabr2.help@gmail.com> Co-authored-by: crapStone <crapstone01@gmail.com> Reviewed-on: https://codeberg.org/Calciumdibromid/CaBr2/pulls/1334 Co-authored-by: Calciumdibromid Bot <cabr2_bot@noreply.codeberg.org> Co-committed-by: Calciumdibromid Bot <cabr2_bot@noreply.codeberg.org>
ronaldslc
pushed a commit
to ronaldslc/serde-json
that referenced
this pull request
Dec 3, 2022
As indicated in the summary of serde-rs#885.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
indexmap's use ofautocfgdoesn't always properly detectstd, which is needed if you're using the defaultShasher. The "indexmap/std" feature will explicitly force it on.This does mean that
preserve_orderrequiresstd, but that was already effectively true by using the defaultS. Alternatively, we could pick ano_stdhasher crate for this, or implement a simple one locally.