Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove simd-json support #2735

Merged
merged 1 commit into from
Jan 24, 2024
Merged

Remove simd-json support #2735

merged 1 commit into from
Jan 24, 2024

Conversation

GnomedDev
Copy link
Member

simd-json is not a performance improvement for serenity, has a ton of sketchy unsafe, and increases the maintenance burden and leads to serenity containing a json compatibility layer(!). This PR just removes all that, although a faster json decoding implementation is on the table in the future if the compatibility layer is kept out of tree and it is measurably faster for serenity's usecase (if benchmark data is wanted, I can probably provide anonymized payloads for a 260k+ guild startup).

@github-actions github-actions bot added model Related to the `model` module. builder Related to the `builder` module. cache Related to the `cache`-feature. http Related to the `http` module. gateway Related to the `gateway` module. examples Related to Serenity's examples. ci Related to the continuous integration. labels Jan 23, 2024
@GnomedDev GnomedDev force-pushed the remove-simd-json branch 2 times, most recently from 2d1f97f to 4dec394 Compare January 23, 2024 22:41
@github-actions github-actions bot added the utils Related to the `utils` module. label Jan 23, 2024
@arqunis arqunis added enhancement An improvement to Serenity. breaking change The public API is changed, resulting in miscompilations or unexpected new behaviour for users dependencies Related to Serenity dependencies. labels Jan 24, 2024
@arqunis arqunis merged commit 4e05d38 into serenity-rs:next Jan 24, 2024
21 checks passed
@GnomedDev GnomedDev deleted the remove-simd-json branch January 24, 2024 21:02
GnomedDev added a commit that referenced this pull request Feb 9, 2024
@GnomedDev
Remove simd-json support (#2735)
efbac5b 
`simd-json` is not a performance improvement for Serenity.

It has a ton of sketchy uses of `unsafe`, increases the maintenance burden, and
leads to Serenity containing a json compatibility layer(!).

This commit removes all that, although a faster json decoding implementation is
on the table in the future if the compatibility layer is kept out of tree and
it is measurably faster for Serenity's usecase.
Erk- added a commit to Erk-/songbird that referenced this pull request Feb 26, 2024
@Erk-
remove simd-json
3d74f19 
This mirrors the serenity pr serenity-rs/serenity#2735.
@Erk- Erk- mentioned this pull request Feb 27, 2024
Merged
Erk- added a commit to Erk-/songbird that referenced this pull request Feb 27, 2024
@Erk-
remove simd-json
04a6743 
This mirrors the serenity pr serenity-rs/serenity#2735.
Erk- added a commit to Erk-/songbird that referenced this pull request Feb 29, 2024
@Erk-
remove simd-json
e32eb5f 
This mirrors the serenity pr serenity-rs/serenity#2735.
Erk- added a commit to serenity-rs/songbird that referenced this pull request Feb 29, 2024
@Erk-
Remove Simd-json (#228)
3149535 
This mirrors the serenity pr serenity-rs/serenity#2735.
arqunis pushed a commit that referenced this pull request Mar 1, 2024
@GnomedDev @arqunis
Remove simd-json support (#2735)
a499067 
`simd-json` is not a performance improvement for Serenity.

It has a ton of sketchy uses of `unsafe`, increases the maintenance burden, and
leads to Serenity containing a json compatibility layer(!).

This commit removes all that, although a faster json decoding implementation is
on the table in the future if the compatibility layer is kept out of tree and
it is measurably faster for Serenity's usecase.
FelixMcFelix pushed a commit to FelixMcFelix/songbird that referenced this pull request Mar 4, 2024
@Erk- @FelixMcFelix
Remove Simd-json (serenity-rs#228)
44c1a91 
This mirrors the serenity pr serenity-rs/serenity#2735.
GnomedDev added a commit that referenced this pull request Mar 10, 2024
@GnomedDev
Remove simd-json support (#2735)
1094c72 
`simd-json` is not a performance improvement for Serenity.

It has a ton of sketchy uses of `unsafe`, increases the maintenance burden, and
leads to Serenity containing a json compatibility layer(!).

This commit removes all that, although a faster json decoding implementation is
on the table in the future if the compatibility layer is kept out of tree and
it is measurably faster for Serenity's usecase.
GnomedDev added a commit that referenced this pull request Mar 11, 2024
@GnomedDev
Remove simd-json support (#2735)
cadecc4 
`simd-json` is not a performance improvement for Serenity.

It has a ton of sketchy uses of `unsafe`, increases the maintenance burden, and
leads to Serenity containing a json compatibility layer(!).

This commit removes all that, although a faster json decoding implementation is
on the table in the future if the compatibility layer is kept out of tree and
it is measurably faster for Serenity's usecase.
GnomedDev added a commit that referenced this pull request Mar 11, 2024
@GnomedDev
Remove simd-json support (#2735)
8a55f03 
`simd-json` is not a performance improvement for Serenity.

It has a ton of sketchy uses of `unsafe`, increases the maintenance burden, and
leads to Serenity containing a json compatibility layer(!).

This commit removes all that, although a faster json decoding implementation is
on the table in the future if the compatibility layer is kept out of tree and
it is measurably faster for Serenity's usecase.
GnomedDev added a commit to GnomedDev/serenity that referenced this pull request Mar 13, 2024
@GnomedDev
Remove simd-json support (serenity-rs#2735)
b3922a3 
`simd-json` is not a performance improvement for Serenity.

It has a ton of sketchy uses of `unsafe`, increases the maintenance burden, and
leads to Serenity containing a json compatibility layer(!).

This commit removes all that, although a faster json decoding implementation is
on the table in the future if the compatibility layer is kept out of tree and
it is measurably faster for Serenity's usecase.
GnomedDev added a commit that referenced this pull request Mar 13, 2024
@GnomedDev
Remove simd-json support (#2735)
9a82e7d 
`simd-json` is not a performance improvement for Serenity.

It has a ton of sketchy uses of `unsafe`, increases the maintenance burden, and
leads to Serenity containing a json compatibility layer(!).

This commit removes all that, although a faster json decoding implementation is
on the table in the future if the compatibility layer is kept out of tree and
it is measurably faster for Serenity's usecase.
GnomedDev added a commit to GnomedDev/serenity that referenced this pull request Mar 19, 2024
@GnomedDev
Remove simd-json support (serenity-rs#2735)
2c76102 
`simd-json` is not a performance improvement for Serenity.

It has a ton of sketchy uses of `unsafe`, increases the maintenance burden, and
leads to Serenity containing a json compatibility layer(!).

This commit removes all that, although a faster json decoding implementation is
on the table in the future if the compatibility layer is kept out of tree and
it is measurably faster for Serenity's usecase.
GnomedDev added a commit to GnomedDev/serenity that referenced this pull request Mar 19, 2024
@GnomedDev
Remove simd-json support (serenity-rs#2735)
8ee3f75 
`simd-json` is not a performance improvement for Serenity.

It has a ton of sketchy uses of `unsafe`, increases the maintenance burden, and
leads to Serenity containing a json compatibility layer(!).

This commit removes all that, although a faster json decoding implementation is
on the table in the future if the compatibility layer is kept out of tree and
it is measurably faster for Serenity's usecase.
GnomedDev added a commit that referenced this pull request Mar 21, 2024
@GnomedDev
Remove simd-json support (#2735)
350fa70 
`simd-json` is not a performance improvement for Serenity.

It has a ton of sketchy uses of `unsafe`, increases the maintenance burden, and
leads to Serenity containing a json compatibility layer(!).

This commit removes all that, although a faster json decoding implementation is
on the table in the future if the compatibility layer is kept out of tree and
it is measurably faster for Serenity's usecase.
GnomedDev added a commit that referenced this pull request Mar 25, 2024
@GnomedDev
Remove simd-json support (#2735)
7f12c0e 
`simd-json` is not a performance improvement for Serenity.

It has a ton of sketchy uses of `unsafe`, increases the maintenance burden, and
leads to Serenity containing a json compatibility layer(!).

This commit removes all that, although a faster json decoding implementation is
on the table in the future if the compatibility layer is kept out of tree and
it is measurably faster for Serenity's usecase.
GnomedDev added a commit that referenced this pull request Mar 25, 2024
@GnomedDev
Remove simd-json support (#2735)
8fd49bf 
`simd-json` is not a performance improvement for Serenity.

It has a ton of sketchy uses of `unsafe`, increases the maintenance burden, and
leads to Serenity containing a json compatibility layer(!).

This commit removes all that, although a faster json decoding implementation is
on the table in the future if the compatibility layer is kept out of tree and
it is measurably faster for Serenity's usecase.
GnomedDev added a commit that referenced this pull request Mar 29, 2024
@GnomedDev
Remove simd-json support (#2735)
1fad535 
`simd-json` is not a performance improvement for Serenity.

It has a ton of sketchy uses of `unsafe`, increases the maintenance burden, and
leads to Serenity containing a json compatibility layer(!).

This commit removes all that, although a faster json decoding implementation is
on the table in the future if the compatibility layer is kept out of tree and
it is measurably faster for Serenity's usecase.
GnomedDev added a commit that referenced this pull request Mar 31, 2024
@GnomedDev
Remove simd-json support (#2735)
be11282 
`simd-json` is not a performance improvement for Serenity.

It has a ton of sketchy uses of `unsafe`, increases the maintenance burden, and
leads to Serenity containing a json compatibility layer(!).

This commit removes all that, although a faster json decoding implementation is
on the table in the future if the compatibility layer is kept out of tree and
it is measurably faster for Serenity's usecase.
GnomedDev added a commit to GnomedDev/serenity that referenced this pull request Mar 31, 2024
@GnomedDev
Remove simd-json support (serenity-rs#2735)
14cd80c 
`simd-json` is not a performance improvement for Serenity.

It has a ton of sketchy uses of `unsafe`, increases the maintenance burden, and
leads to Serenity containing a json compatibility layer(!).

This commit removes all that, although a faster json decoding implementation is
on the table in the future if the compatibility layer is kept out of tree and
it is measurably faster for Serenity's usecase.
GnomedDev added a commit to GnomedDev/serenity that referenced this pull request Apr 1, 2024
@GnomedDev
Remove simd-json support (serenity-rs#2735)
1c13d58 
`simd-json` is not a performance improvement for Serenity.

It has a ton of sketchy uses of `unsafe`, increases the maintenance burden, and
leads to Serenity containing a json compatibility layer(!).

This commit removes all that, although a faster json decoding implementation is
on the table in the future if the compatibility layer is kept out of tree and
it is measurably faster for Serenity's usecase.
GnomedDev added a commit to GnomedDev/serenity that referenced this pull request May 14, 2024
@GnomedDev
Remove simd-json support (serenity-rs#2735)
ceb2af5 
`simd-json` is not a performance improvement for Serenity.

It has a ton of sketchy uses of `unsafe`, increases the maintenance burden, and
leads to Serenity containing a json compatibility layer(!).

This commit removes all that, although a faster json decoding implementation is
on the table in the future if the compatibility layer is kept out of tree and
it is measurably faster for Serenity's usecase.
GnomedDev added a commit that referenced this pull request May 14, 2024
@GnomedDev
Remove simd-json support (#2735)
1d052a0 
`simd-json` is not a performance improvement for Serenity.

It has a ton of sketchy uses of `unsafe`, increases the maintenance burden, and
leads to Serenity containing a json compatibility layer(!).

This commit removes all that, although a faster json decoding implementation is
on the table in the future if the compatibility layer is kept out of tree and
it is measurably faster for Serenity's usecase.
GnomedDev added a commit that referenced this pull request May 23, 2024
@GnomedDev
Remove simd-json support (#2735)
c759e61 
`simd-json` is not a performance improvement for Serenity.

It has a ton of sketchy uses of `unsafe`, increases the maintenance burden, and
leads to Serenity containing a json compatibility layer(!).

This commit removes all that, although a faster json decoding implementation is
on the table in the future if the compatibility layer is kept out of tree and
it is measurably faster for Serenity's usecase.
@jamesbt365 jamesbt365 mentioned this pull request May 25, 2024
Open
GnomedDev added a commit that referenced this pull request May 28, 2024
@GnomedDev
Remove simd-json support (#2735)
597b134 
`simd-json` is not a performance improvement for Serenity.

It has a ton of sketchy uses of `unsafe`, increases the maintenance burden, and
leads to Serenity containing a json compatibility layer(!).

This commit removes all that, although a faster json decoding implementation is
on the table in the future if the compatibility layer is kept out of tree and
it is measurably faster for Serenity's usecase.
GnomedDev added a commit to GnomedDev/serenity that referenced this pull request Jun 9, 2024
@GnomedDev
Remove simd-json support (serenity-rs#2735)
4dac678 
`simd-json` is not a performance improvement for Serenity.

It has a ton of sketchy uses of `unsafe`, increases the maintenance burden, and
leads to Serenity containing a json compatibility layer(!).

This commit removes all that, although a faster json decoding implementation is
on the table in the future if the compatibility layer is kept out of tree and
it is measurably faster for Serenity's usecase.
GnomedDev added a commit that referenced this pull request Jun 22, 2024
@GnomedDev
Remove simd-json support (#2735)
3ed616a 
`simd-json` is not a performance improvement for Serenity.

It has a ton of sketchy uses of `unsafe`, increases the maintenance burden, and
leads to Serenity containing a json compatibility layer(!).

This commit removes all that, although a faster json decoding implementation is
on the table in the future if the compatibility layer is kept out of tree and
it is measurably faster for Serenity's usecase.
GnomedDev added a commit to GnomedDev/serenity that referenced this pull request Jun 22, 2024
@GnomedDev
Remove simd-json support (serenity-rs#2735)
f5f85ce 
`simd-json` is not a performance improvement for Serenity.

It has a ton of sketchy uses of `unsafe`, increases the maintenance burden, and
leads to Serenity containing a json compatibility layer(!).

This commit removes all that, although a faster json decoding implementation is
on the table in the future if the compatibility layer is kept out of tree and
it is measurably faster for Serenity's usecase.
mkrasnitski pushed a commit to mkrasnitski/serenity that referenced this pull request Jul 29, 2024
@GnomedDev @mkrasnitski
Remove simd-json support (serenity-rs#2735)
464b8f7 
`simd-json` is not a performance improvement for Serenity.

It has a ton of sketchy uses of `unsafe`, increases the maintenance burden, and
leads to Serenity containing a json compatibility layer(!).

This commit removes all that, although a faster json decoding implementation is
on the table in the future if the compatibility layer is kept out of tree and
it is measurably faster for Serenity's usecase.
mkrasnitski pushed a commit to mkrasnitski/serenity that referenced this pull request Jul 30, 2024
@GnomedDev @mkrasnitski
Remove simd-json support (serenity-rs#2735)
d707a06 
`simd-json` is not a performance improvement for Serenity.

It has a ton of sketchy uses of `unsafe`, increases the maintenance burden, and
leads to Serenity containing a json compatibility layer(!).

This commit removes all that, although a faster json decoding implementation is
on the table in the future if the compatibility layer is kept out of tree and
it is measurably faster for Serenity's usecase.
tazz4843 pushed a commit to tazz4843/songbird that referenced this pull request Aug 4, 2024
@Erk- @GnomedDev
Remove Simd-json (serenity-rs#228)
e1ab286 
This mirrors the serenity pr serenity-rs/serenity#2735.
GnomedDev pushed a commit to serenity-rs/songbird that referenced this pull request Aug 5, 2024
@Erk- @GnomedDev
Remove Simd-json (#228)
73f4b96 
This mirrors the serenity pr serenity-rs/serenity#2735.
GnomedDev added a commit that referenced this pull request Aug 16, 2024
@GnomedDev
Remove simd-json support (#2735)
1a8793b 
`simd-json` is not a performance improvement for Serenity.

It has a ton of sketchy uses of `unsafe`, increases the maintenance burden, and
leads to Serenity containing a json compatibility layer(!).

This commit removes all that, although a faster json decoding implementation is
on the table in the future if the compatibility layer is kept out of tree and
it is measurably faster for Serenity's usecase.
GnomedDev pushed a commit to GnomedDev/songbird that referenced this pull request Sep 7, 2024
@Erk- @GnomedDev
Remove Simd-json (serenity-rs#228)
209e53a 
This mirrors the serenity pr serenity-rs/serenity#2735.
GnomedDev pushed a commit to serenity-rs/songbird that referenced this pull request Sep 9, 2024
@Erk- @GnomedDev
Remove Simd-json (#228)
05cf36b 
This mirrors the serenity pr serenity-rs/serenity#2735.
GnomedDev added a commit to GnomedDev/serenity that referenced this pull request Oct 7, 2024
@GnomedDev
Remove simd-json support (serenity-rs#2735)
c9d161f 
`simd-json` is not a performance improvement for Serenity.

It has a ton of sketchy uses of `unsafe`, increases the maintenance burden, and
leads to Serenity containing a json compatibility layer(!).

This commit removes all that, although a faster json decoding implementation is
on the table in the future if the compatibility layer is kept out of tree and
it is measurably faster for Serenity's usecase.
GnomedDev added a commit to GnomedDev/serenity that referenced this pull request Oct 20, 2024
@GnomedDev
Remove simd-json support (serenity-rs#2735)
3d0f999 
`simd-json` is not a performance improvement for Serenity.

It has a ton of sketchy uses of `unsafe`, increases the maintenance burden, and
leads to Serenity containing a json compatibility layer(!).

This commit removes all that, although a faster json decoding implementation is
on the table in the future if the compatibility layer is kept out of tree and
it is measurably faster for Serenity's usecase.
GnomedDev added a commit that referenced this pull request Oct 20, 2024
@GnomedDev
Remove simd-json support (#2735)
2f6a824 
`simd-json` is not a performance improvement for Serenity.

It has a ton of sketchy uses of `unsafe`, increases the maintenance burden, and
leads to Serenity containing a json compatibility layer(!).

This commit removes all that, although a faster json decoding implementation is
on the table in the future if the compatibility layer is kept out of tree and
it is measurably faster for Serenity's usecase.
FelixMcFelix pushed a commit to serenity-rs/songbird that referenced this pull request Nov 11, 2024
@Erk- @FelixMcFelix
Remove Simd-json (#228)
77abed2 
This mirrors the serenity pr serenity-rs/serenity#2735.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@arqunis arqunis arqunis approved these changes

Assignees
No one assigned
Labels
breaking change The public API is changed, resulting in miscompilations or unexpected new behaviour for users builder Related to the `builder` module. cache Related to the `cache`-feature. ci Related to the continuous integration. dependencies Related to Serenity dependencies. enhancement An improvement to Serenity. examples Related to Serenity's examples. gateway Related to the `gateway` module. http Related to the `http` module. model Related to the `model` module. utils Related to the `utils` module.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@GnomedDev @arqunis