Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

(next) tracks::create_player missing #140

Closed
vilgotf opened this issue Jul 28, 2022 · 2 comments
Closed

(next) tracks::create_player missing #140

vilgotf opened this issue Jul 28, 2022 · 2 comments
Labels
bug Something isn't working documentation Improvements or additions to documentation tracks Relates to audio control, state, or lifecycle management.
Milestone
v0.4.0: Nightingale

Comments

@vilgotf
Copy link
Contributor

vilgotf commented Jul 28, 2022

Although documented, this function does not exists in the source code, and is impossible to import.
@vilgotf vilgotf changed the title tracks::create_player missing (next) tracks::create_player missing Jul 28, 2022
@FelixMcFelix
Copy link
Member

It's not that it's missing, it's removed -- the docs are wrong, and you're being served an old cached version of the function's docs! It looks as though this somehow survived the swap to the smart intra-doc links, hence why it hasn't come up. I'll modify shortly.

@FelixMcFelix FelixMcFelix added bug Something isn't working documentation Improvements or additions to documentation tracks Relates to audio control, state, or lifecycle management. labels Jul 28, 2022
@FelixMcFelix FelixMcFelix added this to the v0.4.0: Nightingale milestone Jul 28, 2022
FelixMcFelix added a commit to FelixMcFelix/songbird that referenced this issue Jul 28, 2022
@FelixMcFelix
Docs: Fix module docs for songbird::tracks.
dcfe7a5 
Module docs mistakenly used the old doc-link format, so removing `create_player` never fired an error! These have also been partially rewritten to explain the role of `Track` and `TrackHandle`.

Includes some other misc fixes to links, mention of `TrackHandle::action` for metadata handling, etc.

Closes serenity-rs#140.
@FelixMcFelix
Copy link
Member

Okay, should be remedied -- thanks for being so observant!

FelixMcFelix added a commit to FelixMcFelix/songbird that referenced this issue Nov 20, 2023
@FelixMcFelix
Docs: Fix module docs for songbird::tracks.
c1d93f7 
Module docs mistakenly used the old doc-link format, so removing `create_player` never fired an error! These have also been partially rewritten to explain the role of `Track` and `TrackHandle`.

Includes some other misc fixes to links, mention of `TrackHandle::action` for metadata handling, etc.

Closes serenity-rs#140.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working documentation Improvements or additions to documentation tracks Relates to audio control, state, or lifecycle management.
Projects
None yet
Milestone
v0.4.0: Nightingale
Development

No branches or pull requests
2 participants
@FelixMcFelix @vilgotf