Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup of leaky types, nested results #20

Merged
merged 2 commits into from
Dec 4, 2020

Commits on Nov 28, 2020

  1. Cleanup of leaky types

    Main goal: a lot of nested future/result folding.
    
    This mainly modifies error handling for Tracks and TrackHandles to be
    more consistent, and hides the underlying channel result passing in
    get_info. Errors returned should be far clearer, and are domain
    specific rather than falling back to a very opaque use of the underlying
    channel error. It should be clearer to users why their handle commands
    failed, or why they can't make a ytdl track loop or similar.
    
    Also fixed/cleaned up Songbird::join(_gateway) to return in a single
    await, sparing the user from the underlying channel details and repeated
    Errs. I was trying for some time to extend the same graces to `Call`,
    but could not figure out a sane way to get a 'static version of the
    first future in the chain (i.e., the gateway send) so that the whole
    thing could happen after dropping the lock around the Call. I really
    wanted to fix this to happen as a single folded await too, but I think
    this might need some crazy hack or redesign.
    FelixMcFelix committed Nov 28, 2020
    Configuration menu
    Copy the full SHA
    86ea7e9 View commit details
    Browse the repository at this point in the history

Commits on Dec 4, 2020

  1. Configuration menu
    Copy the full SHA
    74f9e11 View commit details
    Browse the repository at this point in the history