Remove typemap from songbird #219
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FelixMcFelix
approved these changes
Jan 21, 2024
FelixMcFelix
pushed a commit
to FelixMcFelix/songbird
that referenced
this pull request
Feb 26, 2024
decahedron1
pushed a commit
to vitri-ent/songbird
that referenced
this pull request
Feb 29, 2024
FelixMcFelix
pushed a commit
to FelixMcFelix/songbird
that referenced
this pull request
Mar 4, 2024
tazz4843
pushed a commit
to tazz4843/songbird
that referenced
this pull request
Aug 4, 2024
GnomedDev
added a commit
that referenced
this pull request
Aug 5, 2024
GnomedDev
added a commit
to GnomedDev/songbird
that referenced
this pull request
Sep 7, 2024
GnomedDev
added a commit
that referenced
this pull request
Sep 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Split off from #218, removes typemap from songbird by using a dyn Any instead. This is already the approach taken for user data in serenity:next.