Make DisposalThread reachable #235
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
The idea of this makes sense (easier to manage disposal thread to driver ratio in non-gateway use cases). However, I think you've made a lot more public than you intended, which is why the docs lint is flagging up. Would this work instead as a pub use tasks::disposal::DisposalThread; in src/driver/mod.rs?
This reverts commit 9cbaae7.
|
I'm sorry about that, i didn't realize how much i was making public with that. You're right, just doing a |
|
Fantastic, thanks very much! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
Configobject provided toCalls andDrivers allows setting aDisposalThread, but since it is unreachable from outside the crate, the only way to properly set it is using aSongbirdinstance, which may not be adequate for all use cases. This PR just makesDisposalThreadreachable from the outside.