Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix(ci): Move problem tests purely to cargo make test #250

Merged
merged 1 commit into from
Aug 24, 2024

Commits on Aug 24, 2024

  1. Fix(ci): Move problem tests purely to cargo make test

    A few tests are routinely failing on CI because they explicitly
    hit YouTube URLs, even if the content in question is CC-licensed.
    This PR simply adds the `#[ignore]` attribute, and adds the
    `--include-ignored` flag to `cargo make test` so that correct WebM
    parsing behaviour can be locally verified.
    
    We could go a bit further and conditionally ignore the tests based
    on CI-specific ENV vars, but that's probably overkill given the
    scope of the issue.
    FelixMcFelix committed Aug 24, 2024
    Configuration menu
    Copy the full SHA
    b4d6d76 View commit details
    Browse the repository at this point in the history