Merge remote-tracking branch 'origin/master' into ssa_interop_server

.bazelci/presubmit.yml

@@ -12,7 +12,7 @@
 ---
 # TODO(yannic): Ideally, we should also enable buildifier and all platforms should test `//...`.
 tasks:
-  ubuntu1804:
+  ubuntu2004:
     build_targets:
       - //:all
       - //src/proto/...

.bazelversion

@@ -1 +1 @@
-6.3.2
+6.4.0

.clang-tidy

@@ -1,15 +1,24 @@
 ---
 # Note on checks are disabled on purpose
 #
+# - abseil-cleanup-ctad
+#   Requires C++17 and higher.
+#
 # - abseil-no-namespace
 #   https://bugs.llvm.org/show_bug.cgi?id=47947
 #
+# - bugprone-exception-escape
+#   https://github.com/llvm/llvm-project/issues/54668 (seems to be fixed in LLVM17)
+#
 # - bugprone-reserved-identifier
 #   Some macros need to be defined for portability purpose; e.g. _BSD_SOURCE.
 #
 # - modernize-redundant-void-arg
 #   Some source should be strictly C99 and func(void) should be used.
 #
+# - google-readability-casting
+#   https://github.com/llvm/llvm-project/issues/57959
+#
 # Note on checks which will be enabled in future. These are good to have but
 # it's not activated yet due to the existing issues with the checks.
 # Once those issues are clear, these checks can be enabled later.
@@ -23,6 +32,7 @@
 # - bugprone-not-null-terminated-result
 # - bugprone-signed-char-misuse
 # - bugprone-sizeof-expression
+# - bugprone-switch-missing-default-case
 # - bugprone-too-small-loop-variable
 # - bugprone-unchecked-optional-access
 # - clang-diagnostic-deprecated-declarations
@@ -41,38 +51,49 @@
 # - modernize-use-equals-default
 # - modernize-use-equals-delete
 # - modernize-use-using
+# - performance-avoid-endl
 # - performance-no-automatic-move
 # - performance-no-int-to-ptr
+# - performance-noexcept-swap
 # - performance-unnecessary-copy-initialization
 # - performance-unnecessary-value-param
 # - readability-else-after-return
 # - readability-implicit-bool-conversion
 # - readability-redundant-declaration
+# - readability-redundant-string-cstr
 #
 Checks: '-*,
   abseil-*,
+  -abseil-cleanup-ctad,
   -abseil-no-namespace,
   bugprone-*,
   -bugprone-assignment-in-if-condition,
   -bugprone-branch-clone,
   -bugprone-easily-swappable-parameters,
+  -bugprone-empty-catch,
+  -bugprone-exception-escape,
   -bugprone-implicit-widening-of-multiplication-result,
   -bugprone-infinite-loop,
   -bugprone-narrowing-conversions,
   -bugprone-not-null-terminated-result,
   -bugprone-reserved-identifier,
   -bugprone-signed-char-misuse,
   -bugprone-sizeof-expression,
+  -bugprone-switch-missing-default-case,
   -bugprone-too-small-loop-variable,
   -bugprone-unchecked-optional-access,
   google-*,
+  -google-readability-casting,
   -google-runtime-int,
   -google-runtime-references,
   performance-*,
+  -performance-avoid-endl,
   -performance-no-automatic-move,
   -performance-no-int-to-ptr,
+  -performance-noexcept-swap,
   -performance-unnecessary-copy-initialization,
   -performance-unnecessary-value-param,
+  clang-diagnostic-deprecated-declarations,
   clang-diagnostic-deprecated-register,
   clang-diagnostic-expansion-to-defined,
   clang-diagnostic-ignored-attributes,
@@ -120,7 +141,7 @@ Checks: '-*,
   readability-redundant-control-flow,
   readability-redundant-function-ptr-dereference,
   readability-redundant-smartptr-get,
-  readability-redundant-string-cstr,
+  -readability-redundant-string-cstr,
   readability-redundant-string-init,
   readability-simplify-boolean-expr,
   readability-static-definition-in-anonymous-namespace,

.gitattributes

@@ -1,5 +1,5 @@
-src/core/ext/upb-generated/** linguist-generated=true
-src/core/ext/upbdefs-generated/** linguist-generated=true
+src/core/ext/upb-gen/** linguist-generated=true
+src/core/ext/upbdefs-gen/** linguist-generated=true
 Makefile linguist-generated=true
 BUILD.gn linguist-generated=true
 CMakeLists.txt linguist-generated=true
@@ -36,4 +36,4 @@ src/core/lib/debug/stats_data.cc linguist-generated=true
 src/core/lib/experiments/experiments.h linguist-generated=true
 src/core/lib/experiments/experiments.cc linguist-generated=true
 bazel/experiments.bzl linguist-generated=true
-test/cpp/microbenchmarks/huffman_geometries/** linguist-generated=true
+test/cpp/microbenchmarks/huffman_geometries/** linguist-generated=true

.github/CODEOWNERS

@@ -1,11 +1,11 @@
-# Auto-generated by the tools/mkowners/mkowners.py tool
-# Uses OWNERS files in different modules throughout the
-# repository as the source of truth for module ownership.
 /**/OWNERS @markdroth @a11r
-/bazel/** @jtattermusch @veblush @gnossen
-/cmake/** @jtattermusch @apolcyn
+/bazel/** @veblush @gnossen
+/bazel/experiments.yaml
+/cmake/** @veblush @apolcyn
 /src/core/ext/filters/client_channel/** @markdroth
+/src/core/ext/transport/chttp2/transport/** @ctiller
 /src/core/ext/xds/** @markdroth
 /src/core/lib/resolver/** @markdroth
 /src/core/lib/service_config/** @markdroth
-/tools/dockerfile/** @jtattermusch @apolcyn
+/tools/dockerfile/** @drfloob @apolcyn @gnossen
+/tools/run_tests/xds_k8s_test_driver/** @sergiitk @XuanWang-Amos @gnossen

.github/ISSUE_TEMPLATE/bug_report_csharp.md

@@ -2,7 +2,7 @@
 name: Report a gRPC C# bug
 about: Create a report to help us improve
 labels: kind/bug, priority/P2, lang/C#
-assignees: jtattermusch
+assignees: apolcyn
 
 ---
 

.github/ISSUE_TEMPLATE/feature_request_csharp.md

@@ -2,7 +2,7 @@
 name: Request a gRPC C# feature
 about: Suggest an idea for this project
 labels: kind/enhancement, priority/P2, lang/C#
-assignees: jtattermusch
+assignees: apolcyn
 
 ---
 

.github/dependabot.yml

@@ -0,0 +1,15 @@
+# To get started with Dependabot version updates, you'll need to specify which
+# package ecosystems to update and where the package manifests are located.
+# Please see the documentation for all configuration options:
+# https://docs.github.com/github/administering-a-repository/configuration-options-for-dependency-updates
+
+version: 2
+updates:
+  - package-ecosystem: "github-actions"
+    directory: "/"
+    schedule:
+      interval: "monthly"
+    groups:
+      github-actions:
+        patterns:
+          - "*"

.github/labeler.yml

@@ -1,60 +1,65 @@
 lang/core:
-- src/abseil-cpp/**
-- src/boringssl/**
-- src/c-ares/**
-- src/core/**
-- src/proto/**
-- src/re2/**
-- src/upb/**
-- src/zlib/**
-- include/grpc/**
-- test/core/**
-- tools/codegen/core/**
-
+  - changed-files:
+      - any-glob-to-any-file:
+          - src/abseil-cpp/**
+          - src/boringssl/**
+          - src/c-ares/**
+          - src/core/**
+          - src/proto/**
+          - src/re2/**
+          - src/upb/**
+          - src/zlib/**
+          - include/grpc/**
+          - test/core/**
+          - tools/codegen/core/**
 lang/c++:
-- examples/cpp/**
-- src/cpp/**
-- include/grpc++/**
-- include/grpcpp/**
-- test/cpp/**
-
+  - changed-files:
+      - any-glob-to-any-file:
+          - examples/cpp/**
+          - src/cpp/**
+          - include/grpc++/**
+          - include/grpcpp/**
+          - test/cpp/**
 area/infra:
-- .github/**
-
+  - changed-files:
+      - any-glob-to-any-file:
+          - .github/**
 lang/node:
-- examples/node/**
-- src/compiler/node*
-
+  - changed-files:
+      - any-glob-to-any-file:
+          - examples/node/**
+          - src/compiler/node*
 lang/ObjC:
-- examples/objective-c/**
-- src/compiler/objective_c*
-- src/objective-c/**
-
+  - changed-files:
+      - any-glob-to-any-file:
+          - examples/objective-c/**
+          - src/compiler/objective_c*
+          - src/objective-c/**
 lang/php:
-- examples/php/**
-- src/compiler/php*
-- src/php/**
-
+  - changed-files:
+      - any-glob-to-any-file:
+          - examples/php/**
+          - src/compiler/php*
+          - src/php/**
 lang/python:
-- bazel/python_rules.bzl
-- examples/python/**
-- requirements.bazel.txt
-- src/compiler/python*
-- any:
-  - src/python/**
-  - "!src/python/grpcio/grpc_core_dependencies.py"
-
+  - changed-files:
+      - any-glob-to-any-file:
+          - bazel/python_rules.bzl
+          - examples/python/**
+          - requirements.bazel.txt
+          - src/compiler/python*
+      - all-globs-to-any-file:
+          - src/python/**
+          - '!src/python/grpcio/grpc_core_dependencies.py'
+          - '!src/python/grpcio_observability/observability_lib_deps.py'
 lang/ruby:
-- examples/ruby/**
-- src/compiler/ruby*
-- src/ruby/**
-
-"lang/C#":
-- src/compiler/csharp*
-- src/csharp/**
-
-"disposition/Needs Internal Changes":
-- src/core/lib/event_engine/windows/**
-- src/core/lib/gpr/windows/**
-- src/core/lib/gprpp/windows/**
-- test/core/event_engine/windows/**
+  - changed-files:
+      - any-glob-to-any-file:
+          - examples/ruby/**
+          - src/compiler/ruby*
+          - src/ruby/**
+'lang/C#':
+  - changed-files:
+      - any-glob-to-any-file:
+          - src/compiler/csharp*
+          - src/csharp/**

.github/workflows/pr-auto-fix.yaml

@@ -12,17 +12,17 @@ jobs:
     steps:
       # Cache bazel build
       - name: Get current time
-        uses: srfrnk/current-time@master
+        uses: srfrnk/current-time@5a4163ad035ccd9a407ec9e519c3b6ba1b633d1e # v1.1.0
         id: current-time
         with:
           format: YYYYWW
       - name: Get current time
-        uses: srfrnk/current-time@master
+        uses: srfrnk/current-time@5a4163ad035ccd9a407ec9e519c3b6ba1b633d1e # v1.1.0
         id: current-time-with-day
         with:
           format: YYYYWWd
       - name: Cache bazel
-        uses: actions/cache@v3
+        uses: actions/cache@13aacd865c20de90d75de3b17ebe84f7a17d57d2 # v4.0.0
         env:
           cache-name: bazel-cache
         with:
@@ -38,18 +38,19 @@ jobs:
       # Cancel current runs if they're still running
       # (saves processing on fast pushes)
       - name: Cancel Previous Runs
-        uses: styfle/cancel-workflow-action@0.9.1
+        uses: styfle/cancel-workflow-action@85880fa0301c86cca9da44039ee3bb12d3bedbfa # 0.12.1
         with:
           access_token: ${{ github.token }}
       # Allow opt-out for some users
       - name: Should I Stay Or Should I Go
-        uses: actions/github-script@v4
+        uses: actions/github-script@60a0d83039c74a4aee543508d2ffcb1c3799cdea # v7.0.1
         id: check
         with:
           script: |
             // If you'd like not to run this code on your commits, add your github user id here:
-            NO_AUTOFIX_USERS = []
+            NO_AUTOFIX_USERS = ["copybara-service[bot]"]
             const { owner, repo } = context.repo
+            console.log("Actor: " + context.actor);
             if (NO_AUTOFIX_USERS.includes(context.actor)) {
               console.log('Cancelling');
               const run_id = "${{ github.run_id }}";
@@ -65,7 +66,7 @@ jobs:
         run: test "${{ steps.check.outputs.result }}" = "stay"
       # Setup to run sanity suite
       - name: Install Python Interpreter
-        uses: actions/setup-python@v4
+        uses: actions/setup-python@0a5c61591373683505ea898e09a3ea4f39ef2b9c # v5.0.0
         with:
           python-version: 3.8
       - name: Install Python Packages
@@ -74,7 +75,7 @@ jobs:
           sudo apt-get update
           sudo apt-get install python3-dev
       - name: Check out repository code
-        uses: actions/checkout@v3
+        uses: actions/checkout@b4ffde65f46336ab88eb53be808477a3936bae11 # v4.1.1
         with:
           submodules: True
       - name: Get the upstream code
@@ -89,7 +90,7 @@ jobs:
         run: ANDROID_NDK_HOME= ${{ github.workspace }}/tools/distrib/sanitize.sh
       # Report back with a PR if things are broken
       - name: Create Pull Request
-        uses: peter-evans/create-pull-request@v3
+        uses: peter-evans/create-pull-request@b1ddad2c994a25fbc81a28b3ec0e368bb2021c50 # v6.0.0
         with:
           delete-branch: true
           branch-suffix: short-commit-hash