Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix ExceptionTokenRenderer to WriteLine after reset sequence #120

Merged
merged 1 commit into from
Oct 21, 2021
Merged

Fix ExceptionTokenRenderer to WriteLine after reset sequence #120

merged 1 commit into from
Oct 21, 2021

Conversation

matkoch
Copy link
Contributor

@matkoch matkoch commented Oct 20, 2021

What issue does this PR address?
Fixes #119

Does this PR introduce a breaking change?
I rather expect that some things magically start working for some users :)

Please check if the PR fulfills these requirements

  • The commit follows our guidelines
  • Unit Tests for the changes have been added (for bug fixes / features)

Other information:
Since there were no breaking tests, I haven't added anything. I figure to properly test this, it would require some more test infrastructure. Hope you're still okay with it.

@nblumhardt
Copy link
Member

LGTM; @serilog/reviewers-core anyone spot any issues/gotchas I might be missing? :-)

@khellang
Copy link
Member

LGTM! 👌🏻

@khellang khellang merged commit c3231ab into serilog:dev Oct 21, 2021
@matkoch
Copy link
Contributor Author

matkoch commented Oct 21, 2021

Can anyone give an estimation when a new version could be released? I'd just like to know if it's worth waiting for my project to push a new NuGet package.

@nblumhardt
Copy link
Member

Hi @matkoch - your changes are in 4.0.1-dev-00879, now on NuGet. We normally publish new "RTM" versions once the -dev-* version containing a change has had some use in the real-world.

If you can deploy the dev version, and let us know how it goes, that would be a useful data point towards planning a new release version.

HTH!

@matkoch
Copy link
Contributor Author

matkoch commented Oct 22, 2021

Can confirm everything is working as expected:

image

@matkoch
Copy link
Contributor Author

matkoch commented Nov 17, 2021

Hey @nblumhardt 👋

can you give any ETA for a release? I'm eagerly waiting to ship my nuget packages with the new serilog integration 😅

@nblumhardt nblumhardt mentioned this pull request Nov 17, 2021
@nblumhardt
Copy link
Member

On it - thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Reset sequence for exceptions is written on next line
3 participants