Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add AuditTo support #141

Merged
merged 4 commits into from
Jul 21, 2023
Merged

Add AuditTo support #141

merged 4 commits into from
Jul 21, 2023

Conversation

sungam3r
Copy link
Contributor

No description provided.

@sungam3r
Copy link
Contributor Author

friendly bump @nblumhardt @SimonCropp

@nblumhardt
Copy link
Member

Thanks @sungam3r 👍

Have you considered whether auditing scenarios to the console might require calls to Console.(Out|Error).Flush()? I haven't looked into whether there's any prior art, but I imagine that if console output is redirected somewhere (e.g. an audit file) then flushing internal buffers would be necessary before the audit event could be considered durable.

@sungam3r
Copy link
Contributor Author

Looking into the code I see that Console.Emit calls Flush in any case: https://github.com/serilog/serilog-sinks-console/blob/dev/src/Serilog.Sinks.Console/Sinks/SystemConsole/ConsoleSink.cs#L59-L78

@nblumhardt
Copy link
Member

LGTM, thanks @sungam3r 👍

CI is broken due to API approval tests

@sungam3r
Copy link
Contributor Author

🤦‍♂️ done

@nblumhardt nblumhardt merged commit ab897eb into serilog:dev Jul 21, 2023
@sungam3r sungam3r deleted the audit branch July 22, 2023 06:05
@nblumhardt nblumhardt mentioned this pull request Nov 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants