Spell check and cleanup #55
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit d2d64b5.
nblumhardt
reviewed
Mar 13, 2019
| @@ -37,8 +37,7 @@ public EventPropertyTokenRenderer(ConsoleTheme theme, PropertyToken token, IForm | |||
| public override void Render(LogEvent logEvent, TextWriter output) | |||
| { | |||
| // If a property is missing, don't render anything (message templates render the raw token here). | |||
| LogEventPropertyValue propertyValue; | |||
| if (!logEvent.Properties.TryGetValue(_token.PropertyName, out propertyValue)) | |||
| if (!logEvent.Properties.TryGetValue(_token.PropertyName, out LogEventPropertyValue propertyValue)) | |||
There was a problem hiding this comment.
My mistake, it fits.
| @@ -66,8 +66,7 @@ int RenderTextToken(TextToken tt, TextWriter output) | |||
|
|
|||
| int RenderPropertyToken(PropertyToken pt, IReadOnlyDictionary<string, LogEventPropertyValue> properties, TextWriter output) | |||
| { | |||
| LogEventPropertyValue propertyValue; | |||
| if (!properties.TryGetValue(pt.PropertyName, out propertyValue)) | |||
| if (!properties.TryGetValue(pt.PropertyName, out LogEventPropertyValue propertyValue)) | |||
| } | ||
|
|
||
| /// <inheritdoc/> | ||
| public IReadOnlyDictionary<ConsoleThemeStyle, SystemConsoleThemeStyle> Styles => _styles; | ||
| public IReadOnlyDictionary<ConsoleThemeStyle, SystemConsoleThemeStyle> Styles { get; private set; } |
There was a problem hiding this comment.
👍 - if assignment only happens in the constructor, this doesn't need private set - { get; } alone will do the job.
|
Thanks, looking good 👍 (I personally consider |
|
I agree. Some StyleCop analyzer rules are controversial. String.Empty is just an obvious expression of intent. |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What issue does this PR address?
Just spell check and cleanup
Does this PR introduce a breaking change?
No