Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Optimization - Use faster null checking #96

Merged
merged 2 commits into from
Jul 23, 2020
Merged

Optimization - Use faster null checking #96

merged 2 commits into from
Jul 23, 2020

Conversation

rafaelsc
Copy link
Contributor

What issue does this PR address?
None

Does this PR introduce a breaking change?
No

Please check if the PR fulfills these requirements

  • The commit follows our guidelines
  • Unit Tests for the changes have been added (for bug fixes / features)

Other Information:

  • Micro-optimization: Replace null checking to use is null to a 'faster' comparison. (Possible a very insignificant improvement)
  • Code Improvement: Add readonly to the static SyncRoot

@rafaelsc rafaelsc changed the title Optimization: Use faster null check Optimization - Use faster null checking Jul 18, 2020
@nblumhardt
Copy link
Member

Nice spotting on the sync root! Let's give this style a shot 👍

@nblumhardt nblumhardt merged commit e992708 into serilog:dev Jul 23, 2020
@rafaelsc rafaelsc deleted the optimization/fastNullCheck branch July 23, 2020 05:49
@nblumhardt nblumhardt mentioned this pull request Jul 12, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rafaelsc @nblumhardt