Add OnFileRemoving life cycle hook #106 #107
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tsimbalar
reviewed
Jul 8, 2019
|
If there is no more issues. Please Merge branch :) |
nblumhardt
reviewed
Jul 12, 2019
|
Thanks for the updates - this is looking good! Did you have a chance to investigate how this might be tested? Here's an example of the other existing hook being tested: https://github.com/serilog/serilog-sinks-file/blob/dev/test/Serilog.Sinks.File.Tests/FileSinkTests.cs#L183 - and here's an example of a rolling test that deals with multiple file deletion: https://github.com/serilog/serilog-sinks-file/blob/dev/test/Serilog.Sinks.File.Tests/RollingFileSinkTests.cs#L56 |
|
Test added |
|
Great! Thanks for the contribution 👍 This should be out as a |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add OnFileRemoving life cycle hook #106