New logFileHeaders parameter added to configuration method #95
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…header text to the log file after a new log file generated
|
Hi! I think @cocowalla's #80 will cover this case (write a hook that emits the headers if the new file stream being wrapped is zero-length). It would be great to have your thoughts on this approach. Cheers! |
Merged
|
Closing as I think we'll initially cover this via #80; thanks again for sending this, hopefully this use case will be covered soon 👍 |
|
Quick note, the latest -dev package on NuGet now supports this, though you need to write the hook yourself; there's an example in: |
|
@kamilozturk @nblumhardt I've just published a NuGet package, Serilog.Sinks.File.Header, which contains a header-writing implementation - just let me know if you encounter any issues |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We want to create a w3c formed special log files. It requires a special #Fields directive before log lines.
If we can do this, we can review our log files via Log Parser Studio tool. So we have created a new logFileHeaders parameter and we have inserted to configuration method to able append header text to the log file after a new log file generated.