Skip to content

Commit

Permalink
Merge pull request #4275 from serlo/fix/editor-web-component-use-shad…
Browse files Browse the repository at this point in the history
…ow-dom-false

fix(editor-web-component): Mark shadow dom as true only when exactly true is passed as attribute
  • Loading branch information
CodingDive authored Nov 13, 2024
2 parents 02a2aec + 57d8667 commit c7ee694
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 2 deletions.
2 changes: 1 addition & 1 deletion packages/editor-web-component/package.json
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "@serlo/editor-web-component",
"version": "0.10.0",
"version": "0.10.1",
"homepage": "https://de.serlo.org/editor",
"bugs": {
"url": "https://github.com/serlo/frontend/issues"
Expand Down
2 changes: 1 addition & 1 deletion packages/editor-web-component/src/editor-web-component.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -76,7 +76,7 @@ export class EditorWebComponent extends HTMLElement {
) {
this.mode = newValue
} else if (name === 'use-shadow-dom') {
this._useShadowDOM = newValue !== 'false'
this._useShadowDOM = newValue === 'true'
} else if (name === 'editor-variant' && oldValue !== newValue) {
this.editorVariant = newValue as EditorVariant
} else if (name === 'plugins' && oldValue !== newValue) {
Expand Down

0 comments on commit c7ee694

Please sign in to comment.