Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(injection): move serlo code back to editor & add server endpoint for fetch #4192

Merged
merged 2 commits into from
Oct 17, 2024

Conversation

elbotho
Copy link
Member

@elbotho elbotho commented Oct 16, 2024

Mostly for PE-157 but solves part of PE-152

Removes graphql code and some serlo imports.
This way it could be used for other integrations in the future.

Copy link

vercel bot commented Oct 16, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
frontend ✅ Ready (Inspect) Visit Preview Oct 16, 2024 7:33pm

@elbotho elbotho marked this pull request as ready for review October 16, 2024 19:35
@elbotho elbotho requested a review from hejtful October 16, 2024 19:35
Copy link
Contributor

📦 Next.js Bundle Analysis for @serlo/frontend

This analysis was generated by the Next.js Bundle Analysis action. 🤖

⚠️ Global Bundle Size Increased

Page Size (compressed)
global 104.59 KB (🟡 +5 B)
Details

The global bundle is the javascript bundle that loads alongside every page. It is in its own category because its impact is much higher - an increase to its size means that every page on your website loads slower, and a decrease means every page loads faster.

Any third party scripts you have added directly to your app using the <script> tag are not accounted for in this analysis

If you want further insight into what is behind the changes, give @next/bundle-analyzer a try!

Twenty Pages Changed Size

The following pages changed size from the code in this PR compared to its base branch:

Page Size (compressed) First Load
/[...slug] 86.77 KB (-8 B) 191.36 KB
/___bot_or_not 101.2 KB (-8 B) 205.79 KB
/___editor_preview 558.8 KB (🟢 -640 B) 663.39 KB
/biologie 155.31 KB (-8 B) 259.9 KB
/chemie 155.31 KB (-8 B) 259.9 KB
/content-only/[...slug] 78.81 KB (-8 B) 183.4 KB
/editor 79.58 KB (-8 B) 184.17 KB
/entity/create/[type]/[taxonomyId] 560.95 KB (🟢 -716 B) 665.54 KB
/entity/repository/add-revision/[...id] 560.63 KB (🟢 -717 B) 665.22 KB
/entity/repository/compare/[entity_id]/[revision_id] 91.51 KB (-8 B) 196.1 KB
/informatik 155.31 KB (-8 B) 259.9 KB
/lerntipps 155.31 KB (-8 B) 259.9 KB
/license/detail/[id] 66.73 KB (🟢 -8 B) 171.32 KB
/mathe 155.31 KB (-8 B) 259.9 KB
/nachhaltigkeit 155.31 KB (-8 B) 259.91 KB
/page/create 560.64 KB (🟢 -718 B) 665.24 KB
/taxonomy/term/create/[parent_id]/[id] 560.38 KB (🟢 -719 B) 664.97 KB
/taxonomy/term/update/[id] 560.3 KB (🟢 -718 B) 664.89 KB
/user/profile/[username] 178.3 KB (-8 B) 282.89 KB
/user/settings 559.51 KB (🟢 -717 B) 664.1 KB
Details

Only the gzipped size is provided here based on an expert tip.

First Load is the size of the global bundle plus the bundle for the individual page. If a user were to show up to your website and land on a given page, the first load size represents the amount of javascript that user would need to download. If next/link is used, subsequent page loads would only need to download that page's bundle (the number in the "Size" column), since the global bundle has already been downloaded.

Any third party scripts you have added directly to your app using the <script> tag are not accounted for in this analysis

Next to the size is how much the size has increased or decreased compared with the base branch of this PR. If this percentage has increased by 20% or more, there will be a red status indicator applied, indicating that special attention should be given to this.

@elbotho elbotho merged commit 9aa9e78 into staging Oct 17, 2024
9 checks passed
@elbotho elbotho deleted the refactor/injection branch October 17, 2024 15:44
@github-actions github-actions bot mentioned this pull request Oct 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants