-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(editor): separate editor and frontend #4207
Conversation
elbotho
commented
Oct 20, 2024
•
edited
Loading
edited
- removes last frontend imports from editor
- removes unused packages in both editor and frontend
- removes import aliases
- cleanup
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
📦 Next.js Bundle Analysis for @serlo/frontendThis analysis was generated by the Next.js Bundle Analysis action. 🤖 Twelve Pages Changed SizeThe following pages changed size from the code in this PR compared to its base branch:
DetailsOnly the gzipped size is provided here based on an expert tip. First Load is the size of the global bundle plus the bundle for the individual page. If a user were to show up to your website and land on a given page, the first load size represents the amount of javascript that user would need to download. If Any third party scripts you have added directly to your app using the Next to the size is how much the size has increased or decreased compared with the base branch of this PR. If this percentage has increased by 20% or more, there will be a red status indicator applied, indicating that special attention should be given to this. |
@@ -1,8 +1,9 @@ | |||
import { cn } from '@editor/utils/cn' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Unrelated to this PR probably, but this looks like a wrong import. It's importing cn
from the editor, even though we have one in web.
@@ -22,7 +22,9 @@ import { | |||
type EditorVariant, | |||
} from './storage-format' | |||
|
|||
import '@/assets-webkit/styles/serlo-tailwind.css' | |||
// TODO: figure out styling |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice that there's already a Linear issue for this! <3