Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(editor): separate editor and frontend #4207

Merged
merged 10 commits into from
Oct 23, 2024

Conversation

elbotho
Copy link
Member

@elbotho elbotho commented Oct 20, 2024

  • removes last frontend imports from editor
  • removes unused packages in both editor and frontend
  • removes import aliases
  • cleanup

Copy link

vercel bot commented Oct 20, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
frontend ✅ Ready (Inspect) Visit Preview Oct 23, 2024 1:57pm

Copy link
Contributor

github-actions bot commented Oct 20, 2024

📦 Next.js Bundle Analysis for @serlo/frontend

This analysis was generated by the Next.js Bundle Analysis action. 🤖

Twelve Pages Changed Size

The following pages changed size from the code in this PR compared to its base branch:

Page Size (compressed) First Load
/___editor_preview 529.42 KB (🟢 -85 B) 634 KB
/___exercise_folder_dashboard/[id] 47.97 KB (🟡 +731 B) 152.55 KB
/editor 79.61 KB (🟢 -14 B) 184.19 KB
/entity/create/[type]/[taxonomyId] 549.49 KB (🟢 -87 B) 654.07 KB
/entity/repository/add-revision/[...id] 549.22 KB (🟢 -87 B) 653.8 KB
/metadata 50.8 KB (🟢 -131 B) 155.38 KB
/page/create 549.21 KB (🟢 -87 B) 653.79 KB
/taxonomy/term/create/[parent_id]/[id] 548.96 KB (🟢 -87 B) 653.54 KB
/taxonomy/term/sort/entities/[id] 97.78 KB (🟡 +11 B) 202.36 KB
/taxonomy/term/update/[id] 548.91 KB (🟢 -87 B) 653.49 KB
/team 48.91 KB (🟢 -125 B) 153.49 KB
/user/settings 550.91 KB (🟢 -87 B) 655.49 KB
Details

Only the gzipped size is provided here based on an expert tip.

First Load is the size of the global bundle plus the bundle for the individual page. If a user were to show up to your website and land on a given page, the first load size represents the amount of javascript that user would need to download. If next/link is used, subsequent page loads would only need to download that page's bundle (the number in the "Size" column), since the global bundle has already been downloaded.

Any third party scripts you have added directly to your app using the <script> tag are not accounted for in this analysis

Next to the size is how much the size has increased or decreased compared with the base branch of this PR. If this percentage has increased by 20% or more, there will be a red status indicator applied, indicating that special attention should be given to this.

@elbotho elbotho changed the base branch from staging to refactor/save-modal October 22, 2024 14:57
Base automatically changed from refactor/save-modal to staging October 22, 2024 17:07
@elbotho elbotho changed the title refactor(editor): wip (all together now) refactor(editor): separate editor and frontend Oct 22, 2024
@elbotho elbotho requested a review from hejtful October 22, 2024 17:19
@elbotho elbotho marked this pull request as ready for review October 22, 2024 17:19
@@ -1,8 +1,9 @@
import { cn } from '@editor/utils/cn'
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unrelated to this PR probably, but this looks like a wrong import. It's importing cn from the editor, even though we have one in web.

@@ -22,7 +22,9 @@ import {
type EditorVariant,
} from './storage-format'

import '@/assets-webkit/styles/serlo-tailwind.css'
// TODO: figure out styling
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice that there's already a Linear issue for this! <3

@elbotho elbotho merged commit 28c634e into staging Oct 23, 2024
9 checks passed
@elbotho elbotho deleted the refactor/all-together-now branch October 23, 2024 13:58
@github-actions github-actions bot mentioned this pull request Oct 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants