Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: plugin hover focus state frame shadow #4277

Draft
wants to merge 4 commits into
base: staging
Choose a base branch
from

Conversation

hejtful
Copy link
Contributor

@hejtful hejtful commented Nov 14, 2024

Issues: DEV-228, DEV-229

Demo

Copy link

vercel bot commented Nov 14, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
frontend ✅ Ready (Inspect) Visit Preview Nov 14, 2024 4:55pm

@hejtful hejtful changed the title feat: plugin hover focus state frame shadow (in progress) feat: plugin hover focus state frame shadow Nov 14, 2024
Copy link
Contributor

github-actions bot commented Nov 14, 2024

📦 Next.js Bundle Analysis for @serlo/frontend

This analysis was generated by the Next.js Bundle Analysis action. 🤖

⚠️ Global Bundle Size Increased

Page Size (compressed)
global 104.46 KB (🟡 +57 B)
Details

The global bundle is the javascript bundle that loads alongside every page. It is in its own category because its impact is much higher - an increase to its size means that every page on your website loads slower, and a decrease means every page loads faster.

Any third party scripts you have added directly to your app using the <script> tag are not accounted for in this analysis

If you want further insight into what is behind the changes, give @next/bundle-analyzer a try!

Twenty-one Pages Changed Size

The following pages changed size from the code in this PR compared to its base branch:

Page Size (compressed) First Load
/[...slug] 87.35 KB (🟢 -9 B) 191.8 KB
/___bot_or_not 101.69 KB (-9 B) 206.15 KB
/___editor_preview 529.73 KB (🟢 -75 B) 634.18 KB
/biologie 155.93 KB (-9 B) 260.38 KB
/chemie 155.93 KB (-9 B) 260.38 KB
/content-only/[...slug] 79.39 KB (🟢 -9 B) 183.85 KB
/editor 80.16 KB (🟢 -9 B) 184.61 KB
/entity/create/[type]/[taxonomyId] 549.81 KB (🟢 -75 B) 654.27 KB
/entity/repository/add-revision/[...id] 549.55 KB (🟢 -75 B) 654 KB
/entity/repository/compare/[entity_id]/[revision_id] 92.06 KB (-9 B) 196.51 KB
/informatik 155.93 KB (-9 B) 260.39 KB
/lerntipps 155.93 KB (-9 B) 260.38 KB
/license/detail/[id] 67.29 KB (🟢 -9 B) 171.75 KB
/mathe 155.92 KB (-9 B) 260.38 KB
/nachhaltigkeit 155.93 KB (-9 B) 260.39 KB
/page/create 549.53 KB (🟢 -75 B) 653.99 KB
/privacy 45.04 KB (-4 B) 149.49 KB
/taxonomy/term/create/[parent_id]/[id] 549.29 KB (🟢 -75 B) 653.75 KB
/taxonomy/term/update/[id] 549.24 KB (🟢 -75 B) 653.69 KB
/user/profile/[username] 178.52 KB (-9 B) 282.98 KB
/user/settings 551.21 KB (🟢 -75 B) 655.67 KB
Details

Only the gzipped size is provided here based on an expert tip.

First Load is the size of the global bundle plus the bundle for the individual page. If a user were to show up to your website and land on a given page, the first load size represents the amount of javascript that user would need to download. If next/link is used, subsequent page loads would only need to download that page's bundle (the number in the "Size" column), since the global bundle has already been downloaded.

Any third party scripts you have added directly to your app using the <script> tag are not accounted for in this analysis

Next to the size is how much the size has increased or decreased compared with the base branch of this PR. If this percentage has increased by 20% or more, there will be a red status indicator applied, indicating that special attention should be given to this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant