Add XDS retry and circuit-breaking functionality to the flow control plugin #1698
Conversation
| # whether to use secure protocol to invoke spring cloud downstream service with xds route, example: http or https | ||
| enabled-springcloud-xds-route-secure: false | ||
| retry: | ||
| retryHostPredicate: PreviousHostsPredicate |
| protected abstract Object buildResult(R requestParam, ExecuteContext context); | ||
|
|
||
| /** | ||
| * build result |
| if (maxRequest != 0 && activeRequestNum > maxRequest) { | ||
| context.skip(buildResult(requestParam, context)); | ||
| } | ||
| businessEntity.setCircuitBusinessName(businessName); |
There was a problem hiding this comment.
setCircuitBreakerBusinessName
| String businessName = buildBusinessName(requestParam, businessEntity); | ||
| int activeRequestNum = CircuitBreakerManager.incrementActiveRequest(businessName); | ||
| int maxRequest = circuitBreakersOptional.get().getMaxRequests(); | ||
| if (maxRequest != 0 && activeRequestNum > maxRequest) { |
There was a problem hiding this comment.
When maxrequest is 0, is maxrequest not configured?
| @Override | ||
| protected String buildBusinessName(Request request, BusinessEntity businessEntity) { | ||
| try { | ||
| URL url = new URL(request.url()); |
There was a problem hiding this comment.
If the entire URL can be directly used as a part of the business, it is not recommended to parse the URL.
| } | ||
| XdsInstanceCircuitBreakers circuitBreakers = instanceCircuitBreakersOptional.get(); | ||
| Response response = (Response) context.getResult(); | ||
| if (response == null) { |
There was a problem hiding this comment.
This is difficult to understand. Can you add comments to the following logic?
| || StringUtils.isEmpty(businessEntity.getCircuitBusinessName())) { | ||
| return context; | ||
| } | ||
| handlerFailureRequest(context, businessEntity); |
There was a problem hiding this comment.
Is the request also a failed request triggered by concurrent circuit breaker? This method is also executed when the circuit breaker is not triggered.
There was a problem hiding this comment.
When there is no trigger, operations such as counting the number of failed requests will be performed.
| Map<String, Collection<String>> headers; | ||
| Map<String, List<String>> responseHeader = flowControlResult.getResponse().getHeaders(); | ||
| if (responseHeader != null) { | ||
| headers = new HashMap<>(responseHeader); | ||
| } else { | ||
| headers = Collections.emptyMap(); | ||
| } |
| if (retryCondition == null) { | ||
| continue; | ||
| } | ||
| boolean needRetry = retryCondition.needRetry(retry, null, conditions, statusCode, result); |
There was a problem hiding this comment.
The retry condition contains the retry status code. Therefore, the retry status code is used to determine whether retry is required.
| @@ -32,7 +32,7 @@ | |||
| public class ChainContext { | |||
| private static final ThreadLocal<Map<String, RequestContext>> THREAD_LOCAL_CONTEXT_MAP = new ThreadLocal<>(); | |||
|
|
|||
| private static final int MAX_SIZE = 8; | |||
| private static final int MAX_SIZE = 11; | |||
There was a problem hiding this comment.
How is MAX_SIZE determined? The following describes the reason why MAX_SIZE is 11.
There was a problem hiding this comment.
Because the handler is added to the XDS, this does not need to be explained.
| value.set(0, value.get(0) + "," + header.getValue()); | ||
| continue; | ||
| } | ||
| headers.put(header.getKey(), Collections.singletonList(header.getValue())); |
There was a problem hiding this comment.
if xdsHeaderOption.isEnabledAppend() is false?
There was a problem hiding this comment.
execute headers.put(header.getKey(), Collections.singletonList(header.getValue()));
| } | ||
| if (xdsHeaderOption.isEnabledAppend() && headers.containsKey(header.getKey())) { | ||
| List<String> value = headers.get(header.getKey()); | ||
| value.set(0, value.get(0) + "," + header.getValue()); |
There was a problem hiding this comment.
why not add the value in list
There was a problem hiding this comment.
The append operation is used to concatenate character strings.
What type of PR is this?
Feature
What this PR does / why we need it?
Add XDS retry and circuit-breaking functionality to the flow control plugin
Which issue(s) this PR fixes？
Fixes #1515
Does this PR introduce a user-facing change?
No
Checklist