Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Is bundler a dependency of turbo tests? #42

Merged
merged 3 commits into from
Sep 29, 2023

Conversation

deivid-rodriguez
Copy link
Contributor

I'm trying to add turbo tests to dependabot-core at dependabot/dependabot-core#8092, but I'm getting an issue due to the dependency on Bundler.

So this is a question-PR. Does turbo tests actually depend on Bundler?

@deivid-rodriguez deivid-rodriguez changed the title Is bundler a dependency iof turbo tests? Is bundler a dependency of turbo tests? Sep 26, 2023
Copy link
Collaborator

@ilyazub ilyazub left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution, @deivid-rodriguez!

I introduced bundle exec in 09f2d37. From what I remember, the reason was the failing turbo_tests execution outside of the turbo_tests repo. (This might be not valid now.)

Also, Bundler is used in the GitHub workflow (I left ${{matrix.env}} here by mistake):

${{matrix.env}} bundle exec turbo_tests -n4

@deivid-rodriguez
Copy link
Contributor Author

Oh, I see, I totally missed that. Thanks!

I believe if we are already in a bundle exec context, we already have the proper ENV setup, so just rspec would use the rspec version in your app context. While if you're not in a bundle exec context, rspec should look for a globally installed rspec version.

So maybe rspec without bundle exec just works.

Copy link
Collaborator

@ilyazub ilyazub left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So maybe rspec without bundle exec just works.

It worked for me locally and on CI (https://github.com/serpapi/turbo_tests/actions/runs/6336870000)

I bumped the version and removed unnecessary matrix.env from the GitHub workflow in 2ae707e.

@deivid-rodriguez
Copy link
Contributor Author

Thanks, I just noticed that the hard dependency on bundler was removed by d0d84ac, so I think it's indeed fine to remove the dependency since it's now optional.

@ilyazub ilyazub merged commit b9e812e into serpapi:master Sep 29, 2023
5 checks passed
@ilyazub
Copy link
Collaborator

ilyazub commented Sep 29, 2023

I just released this PR in turbo_tests v2.2.0

@deivid-rodriguez Thank you for introducing turbo_tests to dependabot! Let's see if helps to fix the ci-test in dependabot/dependabot-core#8092.

@deivid-rodriguez deivid-rodriguez deleted the is-bundler-a-dependency branch September 29, 2023 08:33
@deivid-rodriguez
Copy link
Contributor Author

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants