-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Is bundler a dependency of turbo tests? #42
Is bundler a dependency of turbo tests? #42
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for your contribution, @deivid-rodriguez!
I introduced bundle exec
in 09f2d37. From what I remember, the reason was the failing turbo_tests execution outside of the turbo_tests repo. (This might be not valid now.)
Also, Bundler is used in the GitHub workflow (I left ${{matrix.env}}
here by mistake):
turbo_tests/.github/workflows/tests.yml
Line 29 in ce2ea87
${{matrix.env}} bundle exec turbo_tests -n4 |
Oh, I see, I totally missed that. Thanks! I believe if we are already in a So maybe |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So maybe
rspec
withoutbundle exec
just works.
It worked for me locally and on CI (https://github.com/serpapi/turbo_tests/actions/runs/6336870000)
I bumped the version and removed unnecessary matrix.env
from the GitHub workflow in 2ae707e.
Thanks, I just noticed that the hard dependency on bundler was removed by d0d84ac, so I think it's indeed fine to remove the dependency since it's now optional. |
I just released this PR in turbo_tests v2.2.0 @deivid-rodriguez Thank you for introducing turbo_tests to dependabot! Let's see if helps to fix the ci-test in dependabot/dependabot-core#8092. |
Thank you! |
I'm trying to add turbo tests to dependabot-core at dependabot/dependabot-core#8092, but I'm getting an issue due to the dependency on Bundler.
So this is a question-PR. Does turbo tests actually depend on Bundler?