rustls-ffi: drop clang-asan.patch #234
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously the `rustls-ffi` build setup applied a patch to the upstream `Makefile` to remove unconditional use of ASAN w/ `clang`. This commit removes the patch because it's no longer necessary for two reasons: 1. The package was already migrated to build using `cargo-c` and so wasn't using the `Makefile` anymore. 2. We independently noticed & fixed this bug upstream (fix to be included in the next release). The intent was to only enable ASAN for debug builds, not release builds (the `Makefile` default). Sorry about that!
ikeycode
approved these changes
Aug 8, 2024
There was a problem hiding this comment.
Hey @cpu thanks for the PR and for rustls-ffi! Anywhere we can displace insecure surface area in Serpent OS with libs like this, we will.
I'm not gonna get picky with the PR because honestly our docs are crap and we're still in "open the doors up" mode, so I'll do the relevant bump and build atop this using boulder (from the moss repo)
Thanks! =)
|
Thanks! Don't be shy if you run into any issues w/ rustls-ffi in the future. Happy to help. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi there, I was interested to learn that you're shipping
curlwithrustls-ffiby default. Very cool 🎉While looking at the package definition I noticed you were carrying an extra patch that I think can be dropped. I'm not at all familiar with SerpentOS so hopefully I haven't made any silly errors in this contribution.
Previously the
rustls-ffibuild setup applied a patch to the upstreamMakefileto remove unconditional use of ASAN w/clang. It looks like it was added alongside the original addition ofrustls-ffi. This branch removes the patch because it's no longer necessary for two reasons:cargo-cand so I believe hasn't been using the patchedMakefilesince then.Makefiledefault). Sorry about that!