Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minimalize Dockerfile #378

Merged
merged 5 commits into from
Mar 2, 2018
Merged

Minimalize Dockerfile #378

merged 5 commits into from
Mar 2, 2018

Conversation

RaeesBhatti
Copy link
Contributor

The building of the binary should be done on host. Go can build static binaries for any platform, so, why ship the whole build env with the application!

Copy link
Contributor

@mthenw mthenw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What are the size benefits here comparing to old approach?

Dockerfile Outdated
RUN dep ensure
RUN go build -o event-gateway cmd/event-gateway/main.go

FROM alpine:3.6
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You could just replace this part.

@mthenw mthenw merged commit c955490 into master Mar 2, 2018
@mthenw mthenw deleted the minimalize-dockerfile branch March 2, 2018 08:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants