hide sensitive information in logs #385
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mthenw
changed the title
RaeesBhatti
reviewed
Mar 14, 2018
| c.Lock() | ||
| defer c.Unlock() | ||
| segments := strings.Split(k, "/") | ||
| c.cache[libkv.FunctionKey{Space: segments[0], ID: function.ID(segments[1])}] = f |
There was a problem hiding this comment.
Isn't there a better way to get space? This seems susceptible to changes.
There was a problem hiding this comment.
Not at the moment. That's the only way.
RaeesBhatti
approved these changes
Mar 14, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR hides sensitive information (AWS keys) in logs. It's achieved by implementing
MarshalLogObjectfunction for both Function and Subscription objects. Uber zap then will use it to serialize an object when logging.