-
Notifications
You must be signed in to change notification settings - Fork 97
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Event types #433
Event types #433
Conversation
Codecov Report
@@ Coverage Diff @@
## master #433 +/- ##
==========================================
+ Coverage 63.89% 65.38% +1.48%
==========================================
Files 29 32 +3
Lines 1601 1788 +187
==========================================
+ Hits 1023 1169 +146
- Misses 536 573 +37
- Partials 42 46 +4
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me 👍
What did you implement:
This PR introduces Event Type concept to EG. It allows registering event types that can be consumed by function in a space.
Event types API is an API that allows defining event types on per space basis. Every event emitted to a space has to have type registered beforehand. If there is no event type registered an error is returned by Events API.
Todos:
Is this ready for review?: YES
Is it a breaking change?: YES