Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Event types #433

Merged
merged 19 commits into from
May 28, 2018
Merged

Event types #433

merged 19 commits into from
May 28, 2018

Conversation

mthenw
Copy link
Contributor

@mthenw mthenw commented May 25, 2018

What did you implement:

This PR introduces Event Type concept to EG. It allows registering event types that can be consumed by function in a space.

Event types API is an API that allows defining event types on per space basis. Every event emitted to a space has to have type registered beforehand. If there is no event type registered an error is returned by Events API.

Todos:

  • Write tests
  • Write documentation
  • Fix linting errors
  • Make sure code coverage hasn't dropped
  • Provide verification commands / resources
  • Enable "Allow edits from maintainers" for this PR
  • Update the messages below

Is this ready for review?: YES
Is it a breaking change?: YES

@codecov
Copy link

codecov bot commented May 25, 2018

Codecov Report

Merging #433 into master will increase coverage by 1.48%.
The diff coverage is 76.3%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #433      +/-   ##
==========================================
+ Coverage   63.89%   65.38%   +1.48%     
==========================================
  Files          29       32       +3     
  Lines        1601     1788     +187     
==========================================
+ Hits         1023     1169     +146     
- Misses        536      573      +37     
- Partials       42       46       +4
Impacted Files Coverage Δ
httpapi/config.go 0% <0%> (ø) ⬆️
event/type.go 0% <0%> (ø)
event/errors.go 0% <0%> (ø) ⬆️
internal/cache/target.go 0% <0%> (ø) ⬆️
internal/cache/subscription_cache.go 86.15% <100%> (ø) ⬆️
libkv/function.go 82.27% <100%> (-0.86%) ⬇️
httpapi/metrics.go 100% <100%> (ø) ⬆️
event/event.go 77.41% <100%> (ø) ⬆️
libkv/subscription.go 88.09% <100%> (+0.21%) ⬆️
internal/cache/eventtype_cache.go 100% <100%> (ø)
... and 6 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e4360c6...2d3f90a. Read the comment docs.

@mthenw mthenw changed the title [WIP] Event types Event types May 25, 2018
@mthenw mthenw requested a review from RaeesBhatti May 25, 2018 12:01
Copy link
Contributor

@RaeesBhatti RaeesBhatti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me 👍

@mthenw mthenw merged commit 68bcaf6 into master May 28, 2018
@mthenw mthenw deleted the event-type branch May 28, 2018 12:26
@kenfdev kenfdev mentioned this pull request Jun 3, 2018
@ganeshvlrk ganeshvlrk added this to the 0.8 -- Events API updates milestone Jun 5, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants