-
Notifications
You must be signed in to change notification settings - Fork 97
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add 409 return status code to Config API resources (#465) #466
Conversation
@baniol any idea why TravisCI is not running? |
I have no idea why Travis is not running for this branch. |
@baniol can you login to travisci.org and check if there is no need to accept some ToS or something? |
I don't see anything like that in my account, unfortunately. |
Codecov Report
@@ Coverage Diff @@
## master #466 +/- ##
==========================================
+ Coverage 69.3% 70.78% +1.47%
==========================================
Files 35 35
Lines 2163 2163
==========================================
+ Hits 1499 1531 +32
+ Misses 602 570 -32
Partials 62 62
Continue to review full report at Codecov.
|
@baniol oh, I see. I fixed that. |
@baniol looks great. |
What did you implement:
Modified response status codes from 400 to 409 for POST requests for event types, functions, subscriptions and CORS configs resources. Updated unit tests and API docs accordingly.
How did you implement it:
How can we verify it:
Todos:
I'm not sure if a test for
createSubscription
inhttpapi.go
should be added in scope of the taskIs this ready for review?: NO
Is it a breaking change?: NO