Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for Metadata field in all resources #470

Merged
merged 8 commits into from
Jun 26, 2018
Merged

Add support for Metadata field in all resources #470

merged 8 commits into from
Jun 26, 2018

Conversation

mthenw
Copy link
Contributor

@mthenw mthenw commented Jun 26, 2018

What did you implement:

Closes #435

metadata fields is map[string]string field that allows storing arbitrary key/value pairs and the filtering resources based on those values.

Todos:

  • Write tests
  • Write documentation
  • Fix linting errors
  • Make sure code coverage hasn't dropped
  • Provide verification commands / resources
  • Enable "Allow edits from maintainers" for this PR
  • Update the messages below

Is this ready for review?: YES
Is it a breaking change?: YES

@codecov
Copy link

codecov bot commented Jun 26, 2018

Codecov Report

Merging #470 into master will increase coverage by 0.79%.
The diff coverage is 94.11%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master    #470      +/-   ##
=========================================
+ Coverage    68.5%   69.3%   +0.79%     
=========================================
  Files          34      35       +1     
  Lines        2137    2163      +26     
=========================================
+ Hits         1464    1499      +35     
+ Misses        612     602      -10     
- Partials       61      62       +1
Impacted Files Coverage Δ
event/type.go 0% <ø> (ø) ⬆️
function/function.go 61.53% <100%> (+2.07%) ⬆️
metadata/metadata.go 100% <100%> (ø)
libkv/subscription.go 88.75% <100%> (+0.14%) ⬆️
libkv/function.go 85.18% <100%> (+0.37%) ⬆️
libkv/eventtype.go 86.04% <100%> (+0.33%) ⬆️
httpapi/httpapi.go 82.85% <100%> (+3.1%) ⬆️
libkv/cors.go 86.95% <33.33%> (-1.94%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 28ded18...111ffbf. Read the comment docs.

@mthenw mthenw merged commit 73ba4a3 into master Jun 26, 2018
@mthenw mthenw deleted the metadata branch June 26, 2018 13:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant