Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix deleting function that is used as authorizer #474

Merged
merged 1 commit into from
Jun 29, 2018
Merged

Conversation

mthenw
Copy link
Contributor

@mthenw mthenw commented Jun 29, 2018

What did you implement:

Closes #473

Todos:

  • Write tests
  • Write documentation
  • Fix linting errors
  • Make sure code coverage hasn't dropped
  • Provide verification commands / resources
  • Enable "Allow edits from maintainers" for this PR
  • Update the messages below

Is this ready for review?: YES
Is it a breaking change?: NO

@codecov
Copy link

codecov bot commented Jun 29, 2018

Codecov Report

Merging #474 into master will decrease coverage by 0.04%.
The diff coverage is 60%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #474      +/-   ##
==========================================
- Coverage   70.71%   70.66%   -0.05%     
==========================================
  Files          35       35              
  Lines        2165     2175      +10     
==========================================
+ Hits         1531     1537       +6     
- Misses        571      574       +3     
- Partials       63       64       +1
Impacted Files Coverage Δ
function/errors.go 0% <0%> (ø) ⬆️
httpapi/httpapi.go 90.52% <100%> (+0.04%) ⬆️
libkv/function.go 83.9% <66.66%> (-1.28%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4b892e7...05bc4e3. Read the comment docs.

@mthenw mthenw merged commit 0dd9f87 into master Jun 29, 2018
@mthenw mthenw deleted the fix-delete-auth branch June 29, 2018 11:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant