Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix creating sync subscription for the same method and path (#476) #481

Merged
merged 4 commits into from
Jul 11, 2018

Conversation

mthenw
Copy link
Contributor

@mthenw mthenw commented Jul 11, 2018

This PR fixes creating multiple sync subscription for the same path and method.

Todos:

  • Write tests
  • Write documentation
  • Fix linting errors
  • Make sure code coverage hasn't dropped
  • Provide verification commands / resources
  • Enable "Allow edits from maintainers" for this PR
  • Update the messages below

Is this ready for review?: YES
Is it a breaking change?: YES

@codecov
Copy link

codecov bot commented Jul 11, 2018

Codecov Report

Merging #481 into master will increase coverage by 0.05%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #481      +/-   ##
==========================================
+ Coverage   70.73%   70.78%   +0.05%     
==========================================
  Files          35       35              
  Lines        2180     2184       +4     
==========================================
+ Hits         1542     1546       +4     
  Misses        574      574              
  Partials       64       64
Impacted Files Coverage Δ
libkv/subscription.go 89.02% <100%> (+0.27%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7944da3...34b4419. Read the comment docs.

@mthenw mthenw merged commit 8babc3c into master Jul 11, 2018
@mthenw mthenw deleted the fix-subscription-id branch July 11, 2018 09:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant