Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix redundant system event #489

Merged
merged 1 commit into from
Jul 24, 2018
Merged

Fix redundant system event #489

merged 1 commit into from
Jul 24, 2018

Conversation

mthenw
Copy link
Contributor

@mthenw mthenw commented Jul 24, 2018

What did you implement:

It fixes publishing the same system event twice for sync subscriptions.

Todos:

  • Write tests
  • Write documentation
  • Fix linting errors
  • Make sure code coverage hasn't dropped
  • Provide verification commands / resources
  • Enable "Allow edits from maintainers" for this PR
  • Update the messages below

Is this ready for review?: Yes
Is it a breaking change?: No

@codecov
Copy link

codecov bot commented Jul 24, 2018

Codecov Report

Merging #489 into master will increase coverage by 0.13%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #489      +/-   ##
==========================================
+ Coverage   70.84%   70.97%   +0.13%     
==========================================
  Files          37       37              
  Lines        2195     2188       -7     
==========================================
- Hits         1555     1553       -2     
+ Misses        576      572       -4     
+ Partials       64       63       -1
Impacted Files Coverage Δ
router/router.go 64.91% <100%> (+0.81%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c563910...3ddb82d. Read the comment docs.

@mthenw mthenw merged commit 7944f7a into master Jul 24, 2018
@mthenw mthenw deleted the fix-redundant branch July 24, 2018 20:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants