Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add simple golang http endpoint example #494

Merged
merged 6 commits into from
Aug 1, 2018

Conversation

sebito91
Copy link
Contributor

What did you implement:

Added a golang example of deploying a simple HTTP handler to AWS via hosted event-gateway.

How did you implement it:

Code mimics the example in the main serverless repo but instead of using AWS API Gateway we used the hosted EG.

How can we verify it:

sls deploy -v

Todos:

  • Write tests
  • Write documentation
  • Fix linting errors
  • Make sure code coverage hasn't dropped
  • Provide verification commands / resources
  • Enable "Allow edits from maintainers" for this PR
  • Update the messages below

Is this ready for review?: YES
Is it a breaking change?: NO

@sebito91 sebito91 self-assigned this Jul 31, 2018
@sebito91 sebito91 requested a review from mthenw July 31, 2018 20:14
@sebito91 sebito91 changed the title Simple golang add simple golang http endpoint example Jul 31, 2018
@codecov
Copy link

codecov bot commented Jul 31, 2018

Codecov Report

Merging #494 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff           @@
##           master    #494   +/-   ##
======================================
  Coverage    71.2%   71.2%           
======================================
  Files          37      37           
  Lines        2195    2195           
======================================
  Hits         1563    1563           
  Misses        571     571           
  Partials       61      61

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5c2d4e1...082d502. Read the comment docs.

@sebito91 sebito91 merged commit fb79ad3 into serverless:master Aug 1, 2018
@sebito91 sebito91 deleted the simple_golang branch August 1, 2018 19:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants