-
Notifications
You must be signed in to change notification settings - Fork 5.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
more faithfully represent aws lambda python runtime context #5291
more faithfully represent aws lambda python runtime context #5291
Conversation
@eahefnawy thoughts on this? |
@horike37 / @RafalWilinski reaching out as you folks have ushered in the last few merges to this file. What are your thoughts on this change? |
|
||
@property | ||
def log_stream_name(self): | ||
return '2018/09/12/[$' + self.version + ']58419525dade4d17a495dceeeed44708' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How about actual date? 😄
Left one small comment, other than that, LGTM 💃 |
@RafalWilinski, I pushed a change to address the comment. I used
Let me know what you think. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@softprops
LGTM 👍
thank you so much @horike37! what does the release cycle look like for batching up changes? |
@softprops
We don't decide a definite release cycle. But recent releases looks like every month. |
awesome. I noticed you folks have been releasing a lot lately. I love it! |
What did you implement:
Closes #5283
Brought the python fake local invoke context up to greater parity with aws python runtime context based on the investigation in missing attributes and attribute value type mismatches mentioned in #5283 (comment)
How did you implement it:
I added two new property methods to invoke.py for the two attributes I was missing and corrected the value type of
memory_limit_in_mb
to match that of the aws lambda python runtimeHow can we verify it:
You can essentially follow the same experiment here #5283 (comment)
you can take the off the shelf aws lambda python3.6 runtime template and change it to output the attrs and value types defined on the context object
the compare the output of
serverless invoke local -f hello
vsserverless invoke -f hello
( after deploying it of course )you should see that the value type of
memory_limit_in_mb
is now consistent and the attributeslog_group_name
andlog_stream_name
now exist in both contextsTodos:
Is this ready for review?: YES
Is it a breaking change?: NO