Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Set reserved concurrency in cfn template even if zero #5566

Merged
merged 1 commit into from
Dec 5, 2018
Merged

Set reserved concurrency in cfn template even if zero #5566

merged 1 commit into from
Dec 5, 2018

Conversation

dschep
Copy link
Contributor

@dschep dschep commented Dec 5, 2018

What did you implement:

fixes #5402

How did you implement it:

change the check to be for truthyness or === 0

How can we verify it:

  1. make service with a lambda with zero concurrency
  2. sls package
  3. check that it is set in the cfn template inside .serverless

Todos:

  • Write tests
  • Write documentation
  • Fix linting errors
  • Make sure code coverage hasn't dropped
  • Provide verification config / commands / resources
  • Enable "Allow edits from maintainers" for this PR
  • Update the messages below

Is this ready for review?: YES
Is it a breaking change?: NO

alexdebrie
alexdebrie approved these changes Dec 5, 2018
View reviewed changes
Copy link
Contributor

@alexdebrie alexdebrie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@dschep dschep merged commit 6421135 into master Dec 5, 2018
@dschep dschep deleted the app-5402 branch December 5, 2018 19:27
@dschep dschep mentioned this pull request Dec 12, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexdebrie alexdebrie alexdebrie approved these changes

@horike37 horike37 Awaiting requested review from horike37

@eahefnawy eahefnawy Awaiting requested review from eahefnawy

@pmuens pmuens Awaiting requested review from pmuens

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

reservedConcurrency configuration is not persisting to the stack
2 participants
@dschep @alexdebrie