Replace blocking fs.readFileSync with non blocking fs.readFile in checkForChanges.js #5791
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What did you implement:
Closes: N/A
This PR implements a TODO that was left in
checkForChanges.js
>checkIfDeploymentIsNecessary
which makes reading the zipFiles asynchronously, therefore should make checkForChanges run a bit faster, specially considering there is already a costly blocking operation after the read to compute the checksum per zipFile.How did you implement it:
Simply replaced blocking
fs.readFileSync
with non blockingfs.readFile
.How can we verify it:
N/A
Todos:
Is this ready for review?: YES
Is it a breaking change?: NO