Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Align error logging #5937

Merged
merged 1 commit into from
Mar 18, 2019
Merged

Align error logging #5937

merged 1 commit into from
Mar 18, 2019

Conversation

dnicolson
Copy link
Contributor

What did you implement:

Closes #XXXXX

This pull request fixes the "Your Environment Information" line length so that it aligns with the "Get Support" and "Serverless Error" lines above.

How did you implement it:

How can we verify it:

Todos:

  • Write tests
  • Write documentation
  • Fix linting errors
  • Make sure code coverage hasn't dropped
  • Provide verification config / commands / resources
  • Enable "Allow edits from maintainers" for this PR
  • Update the messages below

Is this ready for review?: YES
Is it a breaking change?: NO

@pmuens pmuens self-assigned this Mar 18, 2019
@pmuens pmuens added this to the 1.40.0 milestone Mar 18, 2019
pmuens
pmuens approved these changes Mar 18, 2019
View reviewed changes
Copy link
Contributor

@pmuens pmuens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM :shipit:

Thanks @dnicolson 👍

@pmuens pmuens merged commit 5619635 into serverless:master Mar 18, 2019
@dschep dschep added the bug label Apr 8, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pmuens pmuens pmuens approved these changes

Assignees

@pmuens pmuens

Labels
bug
Projects
None yet
Milestone
1.40.0
Development

Successfully merging this pull request may close these issues.
3 participants
@dnicolson @pmuens @dschep