Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve post install message #6388

Merged
merged 1 commit into from
Jul 16, 2019
Merged

Improve post install message #6388

merged 1 commit into from
Jul 16, 2019

Conversation

medikoo
Copy link
Contributor

@medikoo medikoo commented Jul 16, 2019

via @skierkowski:

since serverless creates the new folder, we can truncate in a new folder. from the npm i message.

Is it a breaking change?: NO

@medikoo medikoo added this to the 1.48.0 milestone Jul 16, 2019
@medikoo medikoo self-assigned this Jul 16, 2019
@medikoo medikoo requested review from dschep and pmuens July 16, 2019 14:25
pmuens
pmuens approved these changes Jul 16, 2019
View reviewed changes
Copy link
Contributor

@pmuens pmuens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM :shipit:

@medikoo medikoo merged commit e8602f7 into master Jul 16, 2019
@medikoo medikoo deleted the improve-postinstall-message branch July 16, 2019 14:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pmuens pmuens pmuens approved these changes

@dschep dschep Awaiting requested review from dschep

Assignees

@medikoo medikoo

Labels
enhancement
Projects
None yet
Milestone
1.48.0
Development

Successfully merging this pull request may close these issues.
2 participants
@medikoo @pmuens