Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing broken link for Node install. #6405

Merged
merged 2 commits into from
Jul 19, 2019
Merged

Fixing broken link for Node install. #6405

merged 2 commits into from
Jul 19, 2019

Conversation

billfine
Copy link
Contributor

What did you implement:

Closes #XXXXX

How did you implement it:

How can we verify it:

Todos:

Note: Run npm run test-ci to run all validation checks on proposed changes

  • Write tests and confirm existing functionality is not broken.
    Validate via npm test
  • Write documentation
  • Ensure there are no lint errors.
    Validate via npm run lint-updated
    Note: Some reported issues can be automatically fixed by running npm run lint:fix
  • Ensure introduced changes match Prettier formatting.
    Validate via npm run prettier-check-updated
    Note: All reported issues can be automatically fixed by running npm run prettify-updated
  • Make sure code coverage hasn't dropped
  • Provide verification config / commands / resources
  • Enable "Allow edits from maintainers" for this PR
  • Update the messages below

Is this ready for review?: NO
Is it a breaking change?: NO

@billfine billfine requested a review from ganeshvlrk July 19, 2019 01:50
Copy link
Contributor

@ganeshvlrk ganeshvlrk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ganeshvlrk ganeshvlrk merged commit 6c5640e into master Jul 19, 2019
@medikoo medikoo deleted the 7-18-doc-updates branch December 10, 2019 10:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants