Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add graphql function type and selectionSet to functionRef #38

Merged

Conversation

mattgarmon
Copy link
Contributor

Signed-off-by: mattgarmon mjg2790@gmail.com

Many thanks for submitting your Pull Request ❤️!

What this PR does / why we need it:
This PR adds the "graphql" function type to list of function type constants, and adds "selectionSet" to the FunctionRef definition.

GraphQL function type and SelectionSet are defined in the specification here: https://github.com/serverlessworkflow/specification/blob/main/specification.md#using-functions-for-graphql-service-invocations

Special notes for reviewers:

Additional information (if needed):

Signed-off-by: mattgarmon <mjg2790@gmail.com>
@tsurdilo
Copy link
Contributor

tsurdilo commented Aug 4, 2021

@ricardozanini :)

Copy link
Member

@ricardozanini ricardozanini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@tsurdilo thanks!

@ricardozanini ricardozanini merged commit 82a7c16 into serverlessworkflow:main Aug 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants