Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed the OAuth2TokenManager to not validate access token issuer name #426

Merged
merged 1 commit into from
Oct 14, 2024

Conversation

cdavernas
Copy link
Member

@cdavernas cdavernas commented Oct 14, 2024

Many thanks for submitting your Pull Request ❤️!

What this PR does / why we need it:

  • Moves the IOAuth2TokenManager and its implementation from the Infrastructure project to the runner's
  • Fixes the OAuth2TokenManager to not validate access token issuer name
  • Adds environment variable based configuration of the API's JwT issuer, its signing key and its name validation

Signed-off-by: Charles d'Avernas charles.davernas@neuroglia.io

…m the Infrastructure project to the runner's

fix(Runner): Fixed the OAuth2TokenManager to not validate access token issuer name
fix(Api): Added environment variable based configuration of the API's JwT issuer, its signing key and its name validation

Signed-off-by: Charles d'Avernas <charles.davernas@neuroglia.io>
@cdavernas cdavernas added type: bug Something isn't working priority: high Indicates a high priority issue weight: 1 An issue that has a very low development impact app: runner Concerns the Runner labels Oct 14, 2024
@cdavernas cdavernas added this to the v1.0.0 milestone Oct 14, 2024
@cdavernas cdavernas self-assigned this Oct 14, 2024
@cdavernas cdavernas changed the title Fixed the OAuth2TokenManager to not validate access token issuer name Fixed the OAuth2TokenManager to not validate access token issuer name Oct 14, 2024
@cdavernas cdavernas merged commit 288dd84 into main Oct 14, 2024
4 checks passed
@cdavernas cdavernas deleted the fix-runner-jwt-issuer-validation branch October 14, 2024 13:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
app: runner Concerns the Runner priority: high Indicates a high priority issue type: bug Something isn't working weight: 1 An issue that has a very low development impact
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

1 participant