Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Light theme improvements and close button for editor errors in the Dashboard #449

Merged
merged 2 commits into from
Oct 30, 2024
Merged

Light theme improvements and close button for editor errors in the Dashboard #449

merged 2 commits into from
Oct 30, 2024

Conversation

JBBianchi
Copy link
Member

Many thanks for submitting your Pull Request ❤️!

What this PR does / why we need it:

@JBBianchi
fix(Dashboard): improved light theme colors for graph and "..." dropd…
6ba3e73 
…owns

Signed-off-by: Jean-Baptiste Bianchi <jb.bianchi@neuroglia.io>
@JBBianchi
fix(Dashboard): added icon to close editor errors
251c2af 
Closes #447

Signed-off-by: Jean-Baptiste Bianchi <jb.bianchi@neuroglia.io>
@JBBianchi JBBianchi added type: enhancement New feature or request app: dashboard Concerns the Dashboard UI priority: low Indicates a low priority issue weight: 1 An issue that has a very low development impact labels Oct 30, 2024
@JBBianchi JBBianchi added this to the v1.0.0 milestone Oct 30, 2024
@JBBianchi JBBianchi self-assigned this Oct 30, 2024
cdavernas
cdavernas approved these changes Oct 30, 2024
View reviewed changes
Copy link
Member

@cdavernas cdavernas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Cheers ❤️

@cdavernas cdavernas merged commit bb98d91 into main Oct 30, 2024
4 checks passed
@cdavernas cdavernas deleted the fix-dashboard-light-theme branch October 30, 2024 15:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cdavernas cdavernas cdavernas approved these changes

Assignees

@JBBianchi JBBianchi

Labels
app: dashboard Concerns the Dashboard UI priority: low Indicates a low priority issue type: enhancement New feature or request weight: 1 An issue that has a very low development impact
Projects
Progress Tracker
Status: Done
Milestone
v1.0.0
Development

Successfully merging this pull request may close these issues.
2 participants
@JBBianchi @cdavernas