Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove mappings from the ServiceBinding resource #154

Merged
merged 3 commits into from
Jun 14, 2021

Commits on May 14, 2021

  1. Remove mappings from the ServiceBinding resource

    The existing mappings on the ServiceBinding resource were introduced as
    a way to make it easier for a user to enrich an existing Secret into a
    form appropriate for binding to an application workload. This approch
    had a few issues that can be better addressed by other resources that
    interoperate with the ServiceBiding resource. The issues include:
    - the ServiceBinding controller needs to be able to read and write
      Secrets
    - Go templates were used to compose new values, which worked for basic
      templating, but were limited in their capabilities
    - the capabilities of the Go templates are an implemenation detail of
      how the controller is built and could change over time independent of
      the speced behavior.
    
    The behavior applied by mappings can be reintroduced as dedicated
    resources that can themselves expose a Secret as a ProvisionedService,
    which can be consumed by a ServiceBinding. This change further separates
    the concerns of provisioning a service from binding a service.
    
    Refs servicebinding#145
    
    Signed-off-by: Scott Andrews <andrewssc@vmware.com>
    scothis committed May 14, 2021
    Configuration menu
    Copy the full SHA
    9c5594c View commit details
    Browse the repository at this point in the history

Commits on May 25, 2021

  1. Add should/must clarification for .data.type in secrets

    Signed-off-by: Scott Andrews <andrewssc@vmware.com>
    scothis committed May 25, 2021
    Configuration menu
    Copy the full SHA
    bf6c0c0 View commit details
    Browse the repository at this point in the history

Commits on Jun 3, 2021

  1. Restore .spec.type and .spec.provider

    While bring back these fields and the general capability, I removed
    references that mandated these fields be added to a Secret. Instead, the
    requirement is that they are part of the application projection.
    Implementors can figure out the best way to make that happen, either by
    creating a derivative Secret, or by using a projected volume.
    
    Signed-off-by: Scott Andrews <andrewssc@vmware.com>
    scothis committed Jun 3, 2021
    Configuration menu
    Copy the full SHA
    dbd7105 View commit details
    Browse the repository at this point in the history