Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

implement full NSMenu and NSMenuItem APIs #507

Closed
wants to merge 5 commits into from

Conversation

lunixbochs
Copy link

No description provided.

@lunixbochs
Copy link
Author

lunixbochs commented Apr 25, 2022

what's the convention for handling overlapping selectors? do we just delete all but one if they're compatible?

   = note: candidate #1 is defined in an impl of the trait `NSMenu` for the type `*mut objc::runtime::Object`
346   = note: candidate #2 is defined in an impl of the trait `NSMenuItem` for the type `*mut objc::runtime::Object`
347   = note: candidate #3 is defined in an impl of the trait `NSWindow` for the type `*mut objc::runtime::Object`
348help: disambiguate the associated function for candidate #1
349   |
35079 |     NSMenu::setTitle_(window, title);
351   |     ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
352help: disambiguate the associated function for candidate #2
353   |
35479 |     NSMenuItem::setTitle_(window, title);
355   |     ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
356help: disambiguate the associated function for candidate #3
357   |
35879 |     NSWindow::setTitle_(window, title);
359   |     ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
360
361

Edit: Ahh, no, deleting redundant ones doesn't work very well, because you might not be importing the other traits :/

Is there any better answer here than making this a breaking change?

@bors-servo
Copy link
Contributor

☔ The latest upstream changes (presumably b009c87) made this pull request unmergeable. Please resolve the merge conflicts.

@lunixbochs
Copy link
Author

it's been 15 months, I assume if someone wanted to merge this they would have by now

@lunixbochs lunixbochs closed this Jul 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants