Add visionOS and watchOS to linking to CoreFoundation framework #679
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
madsmtm
approved these changes
May 22, 2024
No worries. It's part of nightly and using tier 3 targets. We'll eventually patch all the links. |
jdm
approved these changes
May 22, 2024
auto-merge was automatically disabled
May 22, 2024 16:06
Head branch was pushed to by a user without write access
simlay
force-pushed
the
add-watchos-and-visionos-for-core-foundation-linking
branch
from
1f80660
to
178b6ac
Compare
|
@jdm CI failed on rustfmt so I |
|
Uh, the auto merge merged the unfmt'd commit? Now CI is red. It ignored my push to fix rustfmt and claims the PR is merged when there's obviously an unmerged commit. I expect better of this free software (github). |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using a few patches for various tls and security framework features to build for visionOS and watchOS (among other apple targets), I ran into a linking error.
In rust-lang/rust#125225, linking to Foundation was removed which I think caused some link errors for visionOS and watchOS on rust nightly-2024-05-22.
These are the fixes to those errors.