core-foundation: Use dep syntax for with-uuid feature.
#691
Conversation
|
Dep syntax needs MSRV 1.60 or later. |
|
You'll also need to update the MSRV in this change in the |
|
@mrobinson Any preference what it gets updated to? |
I suppose we should shoot for the oldest version possible. |
waywardmonkeys
force-pushed
the
use-explicit-dep-for-uuid
branch
from
cbb7f76
to
2d1db9c
Compare
|
@mrobinson For now, I only bumped it in the CI job. I'd rather do a full separate PR that fixes up the package info to include the |
|
Also, I've bumped to 1.64 rather than 1.60 as that'll get us the features for #692 and also workspace dependencies and package settings. |
|
The most common dependency of this crate is |
|
Okay. 1.65 seems reasonable. |
|
@mrobinson Would've been nice to have gotten a heads up that a new version was going to be published, including a breaking semver and we could've gotten this landed ... Not sure why I bother with any of these PRs. |
This removes an implicit feature due to the optional dependency `uuid`. While this is user visible, any use of `uuid` as a feature previously would not have enabled the support code and so it wouldn't have had any benefit.
waywardmonkeys
force-pushed
the
use-explicit-dep-for-uuid
branch
from
2d1db9c
to
ab88b21
Compare
|
@jdm @mrobinson This too is good to go for review. |
waywardmonkeys
force-pushed
the
use-explicit-dep-for-uuid
branch
from
9c6db75
to
ab88b21
Compare
This removes an implicit feature due to the optional dependency
uuid.While this is user visible, any use of
uuidas a feature previously would not have enabled the support code and so it wouldn't have had any benefit.Bump the MSRV in CI to 1.64 (while only 1.60 is required here, other features from 1.64 will be used).