Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for * prefix in declaration names #388

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

hamidrezakp
Copy link

Hey
This is a hacky fix for adding support of legacy * prefixes to cssparser.

Currently this fails to be parsed:

p {
    *color: red;
}

And there is a good reason to it, This legacy syntax is only used for ie 6/7 and it's not valid css3 grammar too.

But some libraries and old codebases still depend on this kind of properties to work on old browsers.

I know this is not a correct way to do it, but if you have plans to add this feature to parser, i can prepare another fix that uses feature-gates in cargo.toml and has proper parsing methods for handling this kind of syntax.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant