Skip to content

Commit

Permalink
Re-enable improper_ctypes lint on bindings and update CI (#73)
Browse files Browse the repository at this point in the history
* Re-enable improper_ctypes lint on bindings

The linked issue rust-lang/rust#34798
has since been fixed, and rust will not warn if
PhantomData is used in FFI structs.
See also: rust-lang/rust#39462

* Update ci.yml

Fixes warnings on github actions about updating to
Node v20 by updating the used actions.
actions-rs/toolchain is not maintained anymore, switch
to dtolnay/rust-toolchain instead.
  • Loading branch information
jschwe authored Apr 23, 2024
1 parent 8885917 commit 2f05276
Show file tree
Hide file tree
Showing 2 changed files with 6 additions and 12 deletions.
16 changes: 5 additions & 11 deletions .github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -12,20 +12,14 @@ jobs:
matrix:
toolchain: [stable, beta, nightly]
name: Rust
runs-on: ubuntu-20.04
runs-on: ubuntu-22.04
steps:
- uses: actions/checkout@v3
- uses: actions-rs/toolchain@v1
- uses: actions/checkout@v4
- uses: dtolnay/rust-toolchain@master
with:
profile: minimal
override: true
toolchain: ${{ matrix.toolchain }}
- uses: actions-rs/cargo@v1
name: Build
with:
command: build
- uses: actions-rs/cargo@v1
name: Test
with:
command: test
- run: cargo build
- run: cargo test

2 changes: 1 addition & 1 deletion src/lib.rs
Original file line number Diff line number Diff line change
Expand Up @@ -27,6 +27,6 @@ pub fn succeeded(error: FT_Error) -> bool {
error == freetype::FT_Err_Ok as FT_Error
}

#[allow(improper_ctypes)] // https://github.com/rust-lang/rust/issues/34798
#[deny(improper_ctypes)]
pub mod freetype;
pub mod tt_os2;

0 comments on commit 2f05276

Please sign in to comment.