Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement Clone for IntoIter<A> where A: Clone #192

Merged
merged 2 commits into from
Dec 13, 2019

Conversation

L0uisc
Copy link
Contributor

@L0uisc L0uisc commented Dec 12, 2019

Implemented code to fix #178. The commented impl can be uncommented once specialization is possible. Both impls were tested and passed the three added tests.

Copy link
Collaborator

@mbrubeck mbrubeck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! One minor change and then this is ready for approval:

lib.rs Outdated Show resolved Hide resolved
@mbrubeck
Copy link
Collaborator

@bors-servo r+

@bors-servo
Copy link
Contributor

📌 Commit 1fa1545 has been approved by mbrubeck

@bors-servo
Copy link
Contributor

⌛ Testing commit 1fa1545 with merge 941d6aa...

bors-servo pushed a commit that referenced this pull request Dec 13, 2019
Implement Clone for IntoIter<A> where A: Clone

Implemented code to fix #178. The commented impl can be uncommented once specialization is possible. Both impls were tested and passed the three added tests.
@bors-servo
Copy link
Contributor

☀️ Test successful - checks-travis
Approved by: mbrubeck
Pushing 941d6aa to master...

@bors-servo bors-servo merged commit 1fa1545 into servo:master Dec 13, 2019
mbrubeck added a commit to mbrubeck/rust-smallvec that referenced this pull request Dec 19, 2019
Changes in this release:

* Added new method `SmallVec::into_boxed_slice` (servo#190).
* Added new method `IntoIter::as_slice` (servo#182).
* `IntoIter` now implements `Clone` (servo#192).
* Improved documentation and testing (servo#186, servo#189).
* Minor code cleanups (servo#176).
@mbrubeck mbrubeck mentioned this pull request Dec 19, 2019
bors-servo pushed a commit that referenced this pull request Dec 20, 2019
Version 1.1.0

Changes in this release:

* Added new method `SmallVec::into_boxed_slice` (#190).
* Added new methods `IntoIter::as_slice` and `as_mut_slice` (#182).
* `IntoIter` now implements `Clone` (#192).
* Improved documentation and testing (#186, #189).
* Minor code cleanups (#176).

Also added a simple example to the README.
@L0uisc L0uisc deleted the clone-into-iter branch November 17, 2022 17:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Implement Clone for IntoIter<A: Array> where A: Clone
3 participants