Implemented DrainFilter #292
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I've reviewed this now, and I'm now doubly sure it does what it should. Review by another human would be appreciated, but from my side, I think it's good to go. |
|
Anything I still need to do with this? |
|
Sorry for the delay. I'll try to review this soon (if another maintainer doesn't get to it first). |
|
No worries! I just wanted to confirm if I still need to do something before the review process can start. |
|
☔ The latest upstream changes (presumably #298) made this pull request unmergeable. Please resolve the merge conflicts. |
|
@bors-servo r+ Sorry for the wait! |
|
📌 Commit ae7ff95 has been approved by |
|
☀️ Test successful - checks-github |
Merged
matzemathics
added a commit
to matzemathics/rust-smallvec
that referenced
this pull request
Jan 14, 2024
matzemathics
added a commit
to matzemathics/rust-smallvec
that referenced
this pull request
Jan 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Provides an implementation for DrainFilter (issue #281).