Skip to content

Commit

Permalink
url: more regressed clippy suppressions
Browse files Browse the repository at this point in the history
Regressed in 6fd1e87.
  • Loading branch information
djc committed Apr 6, 2021
1 parent d39870e commit ce37627
Show file tree
Hide file tree
Showing 2 changed files with 15 additions and 15 deletions.
18 changes: 9 additions & 9 deletions url/src/lib.rs
Original file line number Diff line number Diff line change
Expand Up @@ -1434,7 +1434,7 @@ impl Url {
/// Return an object with methods to manipulate this URL’s path segments.
///
/// Return `Err(())` if this URL is cannot-be-a-base.
#[allow(clippy::result_map_unit_fn)]
#[allow(clippy::result_unit_err)]
pub fn path_segments_mut(&mut self) -> Result<PathSegmentsMut<'_>, ()> {
if self.cannot_be_a_base() {
Err(())
Expand Down Expand Up @@ -1518,7 +1518,7 @@ impl Url {
/// # }
/// # run().unwrap();
/// ```
#[allow(clippy::result_map_unit_fn)]
#[allow(clippy::result_unit_err)]
pub fn set_port(&mut self, mut port: Option<u16>) -> Result<(), ()> {
// has_host implies !cannot_be_a_base
if !self.has_host() || self.host() == Some(Host::Domain("")) || self.scheme() == "file" {
Expand Down Expand Up @@ -1789,7 +1789,7 @@ impl Url {
/// # run().unwrap();
/// ```
///
#[allow(clippy::result_map_unit_fn)]
#[allow(clippy::result_unit_err)]
pub fn set_ip_host(&mut self, address: IpAddr) -> Result<(), ()> {
if self.cannot_be_a_base() {
return Err(());
Expand Down Expand Up @@ -1829,7 +1829,7 @@ impl Url {
/// # }
/// # run().unwrap();
/// ```
#[allow(clippy::result_map_unit_fn)]
#[allow(clippy::result_unit_err)]
pub fn set_password(&mut self, password: Option<&str>) -> Result<(), ()> {
// has_host implies !cannot_be_a_base
if !self.has_host() || self.host() == Some(Host::Domain("")) || self.scheme() == "file" {
Expand Down Expand Up @@ -1922,7 +1922,7 @@ impl Url {
/// # }
/// # run().unwrap();
/// ```
#[allow(clippy::result_map_unit_fn)]
#[allow(clippy::result_unit_err)]
pub fn set_username(&mut self, username: &str) -> Result<(), ()> {
// has_host implies !cannot_be_a_base
if !self.has_host() || self.host() == Some(Host::Domain("")) || self.scheme() == "file" {
Expand Down Expand Up @@ -2084,7 +2084,7 @@ impl Url {
/// # }
/// # run().unwrap();
/// ```
#[allow(clippy::result_map_unit_fn, clippy::suspicious_operation_groupings)]
#[allow(clippy::result_unit_err, clippy::suspicious_operation_groupings)]
pub fn set_scheme(&mut self, scheme: &str) -> Result<(), ()> {
let mut parser = Parser::for_setter(String::new());
let remaining = parser.parse_scheme(parser::Input::new(scheme))?;
Expand Down Expand Up @@ -2164,7 +2164,7 @@ impl Url {
/// # }
/// ```
#[cfg(any(unix, windows, target_os = "redox"))]
#[allow(clippy::result_map_unit_fn)]
#[allow(clippy::result_unit_err)]
pub fn from_file_path<P: AsRef<Path>>(path: P) -> Result<Url, ()> {
let mut serialization = "file://".to_owned();
let host_start = serialization.len() as u32;
Expand Down Expand Up @@ -2201,7 +2201,7 @@ impl Url {
/// Note that `std::path` does not consider trailing slashes significant
/// and usually does not include them (e.g. in `Path::parent()`).
#[cfg(any(unix, windows, target_os = "redox"))]
#[allow(clippy::result_map_unit_fn)]
#[allow(clippy::result_unit_err)]
pub fn from_directory_path<P: AsRef<Path>>(path: P) -> Result<Url, ()> {
let mut url = Url::from_file_path(path)?;
if !url.serialization.ends_with('/') {
Expand Down Expand Up @@ -2318,7 +2318,7 @@ impl Url {
/// for a Windows path, is not UTF-8.)
#[inline]
#[cfg(any(unix, windows, target_os = "redox"))]
#[allow(clippy::result_map_unit_fn)]
#[allow(clippy::result_unit_err)]
pub fn to_file_path(&self) -> Result<PathBuf, ()> {
if let Some(segments) = self.path_segments() {
let host = match self.host() {
Expand Down
12 changes: 6 additions & 6 deletions url/src/quirks.rs
Original file line number Diff line number Diff line change
Expand Up @@ -56,7 +56,7 @@ pub fn protocol(url: &Url) -> &str {
}

/// Setter for https://url.spec.whatwg.org/#dom-url-protocol
#[allow(clippy::result_map_unit_fn)]
#[allow(clippy::result_unit_err)]
pub fn set_protocol(url: &mut Url, mut new_protocol: &str) -> Result<(), ()> {
// The scheme state in the spec ignores everything after the first `:`,
// but `set_scheme` errors if there is more.
Expand All @@ -73,7 +73,7 @@ pub fn username(url: &Url) -> &str {
}

/// Setter for https://url.spec.whatwg.org/#dom-url-username
#[allow(clippy::result_map_unit_fn)]
#[allow(clippy::result_unit_err)]
pub fn set_username(url: &mut Url, new_username: &str) -> Result<(), ()> {
url.set_username(new_username)
}
Expand All @@ -85,7 +85,7 @@ pub fn password(url: &Url) -> &str {
}

/// Setter for https://url.spec.whatwg.org/#dom-url-password
#[allow(clippy::result_map_unit_fn)]
#[allow(clippy::result_unit_err)]
pub fn set_password(url: &mut Url, new_password: &str) -> Result<(), ()> {
url.set_password(if new_password.is_empty() {
None
Expand All @@ -101,7 +101,7 @@ pub fn host(url: &Url) -> &str {
}

/// Setter for https://url.spec.whatwg.org/#dom-url-host
#[allow(clippy::result_map_unit_fn)]
#[allow(clippy::result_unit_err)]
pub fn set_host(url: &mut Url, new_host: &str) -> Result<(), ()> {
// If context object’s url’s cannot-be-a-base-URL flag is set, then return.
if url.cannot_be_a_base() {
Expand Down Expand Up @@ -158,7 +158,7 @@ pub fn hostname(url: &Url) -> &str {
}

/// Setter for https://url.spec.whatwg.org/#dom-url-hostname
#[allow(clippy::result_map_unit_fn)]
#[allow(clippy::result_unit_err)]
pub fn set_hostname(url: &mut Url, new_hostname: &str) -> Result<(), ()> {
if url.cannot_be_a_base() {
return Err(());
Expand Down Expand Up @@ -200,7 +200,7 @@ pub fn port(url: &Url) -> &str {
}

/// Setter for https://url.spec.whatwg.org/#dom-url-port
#[allow(clippy::result_map_unit_fn)]
#[allow(clippy::result_unit_err)]
pub fn set_port(url: &mut Url, new_port: &str) -> Result<(), ()> {
let result;
{
Expand Down

0 comments on commit ce37627

Please sign in to comment.