Align mime type parser to spec #749
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lucacasonato
force-pushed
the
mime_parser_fix
branch
6 times, most recently
from
5a630fc to
497e904
Compare
|
☔ The latest upstream changes (presumably #751) made this pull request unmergeable. Please resolve the merge conflicts. |
lucacasonato
force-pushed
the
mime_parser_fix
branch
2 times, most recently
from
fb0f690 to
d75202d
Compare
The most notable two changes are: a) the parser now uses html whitespace instead of ascii whitespace b) the parser now correctly handles empty quoted values The commit additionally fixes a bug in the parser that would fail parsing if an invalid name was encountered and its corresponding value contained a quoted semicolon.
lucacasonato
force-pushed
the
mime_parser_fix
branch
from
d75202d to
8d72494
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The most notable two changes are:
a) the parser now uses html whitespace instead of ascii whitespace (whatwg/mimesniff@126286a)
b) the parser now correctly handles empty quoted values (whatwg/mimesniff@190c18a)
The commit additionally fixes a bug in the parser that would fail
parsing if an invalid name was encountered and its corresponding value
contained a quoted semicolon.
The regression tests for that last issue have been upstreamed to WPT
here: web-platform-tests/wpt#32593.